Skip to content

feat(swarm): deprecate KeepAlive::Until#4656

Merged
mergify[bot] merged 3 commits intomasterfrom
feat/deprecate-keep-alive-until
Oct 16, 2023
Merged

feat(swarm): deprecate KeepAlive::Until#4656
mergify[bot] merged 3 commits intomasterfrom
feat/deprecate-keep-alive-until

Conversation

@thomaseizinger
Copy link
Copy Markdown
Contributor

Description

In preparation for removing this variant, we are issuing a deprecation notice. The linked issue describes why and guides users in migrating away from it. This deprecation is backwards-compatible and allows us to remove the variant in the next breaking release. We haven't migrated all internal protocols yet but that isn't strictly necessary to issue the deprecation.

Related: #3844.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify

This comment was marked as resolved.

@mergify mergify bot merged commit 7c6f75e into master Oct 16, 2023
@mergify mergify bot deleted the feat/deprecate-keep-alive-until branch October 16, 2023 16:32
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
`KeepAlive::Until` is being deprecated. We emulate the functionality within the `ConnectionHandler` to ensure relayed connections don't get immediately closed when a client establishes one.

Related: #3844.
Related: #4656.

Pull-Request: #4676.
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants