Add a workflow for NMAKE#1687
Conversation
|
Interesting |
|
This will close #1395. |
|
We need to keep in mind that we want to further reduce the CI load. It could be an option to not run this one on every commit to a pull request branch, but e.g. only when a branch is merged into master, like we do for some other workflows, or e.g. once a week. We also want to become less dependent on Github. This means that, while it's fine to keep using Github CI for now to run checks for us, we should make sure to keep the Github workflow files as minimal as possible (especially when adding new ones). This new workflow file looks fairly minimal already, not sure we can reduce it further. |
|
@LeonarddeR is it worth merging this considering that nmake on windows doesn't seem to work anyway (#1689)? |
|
Yes, I think we should close this for now. |
|
Well, wait a minute, let's not throw out baby with the bathwater. I think it would be good to have this workflow. If need be we can disable it. |
|
Looks like we have the following options:
The first option doesn't really appeal to me as we have a non-working gh action lying around. I like it even less if we enable it and ignore the result. |
|
OK for me |
|
That's fine |
To avoid future cases were the Windows MSVC build breaks without us noticing, here is a simple straight forward github workflow to monitor this.