Skip to content

Add a workflow for NMAKE#1687

Draft
LeonarddeR wants to merge 5 commits into
liblouis:masterfrom
LeonarddeR:githubNmake
Draft

Add a workflow for NMAKE#1687
LeonarddeR wants to merge 5 commits into
liblouis:masterfrom
LeonarddeR:githubNmake

Conversation

@LeonarddeR

Copy link
Copy Markdown
Member

To avoid future cases were the Windows MSVC build breaks without us noticing, here is a simple straight forward github workflow to monitor this.

@bertfrees bertfrees added build system Anything related to Autotools, the Windows build, CI, Fuzz, etc. windows Related to Microsoft Windows labels Dec 2, 2024
@egli

egli commented Dec 3, 2024

Copy link
Copy Markdown
Member

Interesting

@egli egli added this to the 3.33 milestone Dec 3, 2024
@bertfrees bertfrees added the needs fixup Branch needs cleaning up before it's merged. Don't press any buttons! label Jan 9, 2025
@bertfrees

Copy link
Copy Markdown
Member

This will close #1395.

@bertfrees

bertfrees commented Jan 9, 2025

Copy link
Copy Markdown
Member

We need to keep in mind that we want to further reduce the CI load. It could be an option to not run this one on every commit to a pull request branch, but e.g. only when a branch is merged into master, like we do for some other workflows, or e.g. once a week.

We also want to become less dependent on Github. This means that, while it's fine to keep using Github CI for now to run checks for us, we should make sure to keep the Github workflow files as minimal as possible (especially when adding new ones). This new workflow file looks fairly minimal already, not sure we can reduce it further.

@bertfrees bertfrees self-assigned this Feb 19, 2025
@bertfrees bertfrees self-requested a review February 19, 2025 14:24
@egli egli self-assigned this Feb 19, 2025
@egli

egli commented Feb 19, 2025

Copy link
Copy Markdown
Member

@LeonarddeR is it worth merging this considering that nmake on windows doesn't seem to work anyway (#1689)?

@LeonarddeR

Copy link
Copy Markdown
Member Author

Yes, I think we should close this for now.

@LeonarddeR LeonarddeR closed this Feb 20, 2025
@egli

egli commented Feb 20, 2025

Copy link
Copy Markdown
Member

Well, wait a minute, let's not throw out baby with the bathwater. I think it would be good to have this workflow. If need be we can disable it.

@LeonarddeR LeonarddeR reopened this Feb 20, 2025
@bertfrees bertfrees removed their assignment Feb 26, 2025
@egli

egli commented Feb 27, 2025

Copy link
Copy Markdown
Member

Looks like we have the following options:

  1. Merge the PR and disable the workflow
  2. Convert to a draft and wait until NMAKE on Windows is broken #1689 is fixed
  3. Close the PR

The first option doesn't really appeal to me as we have a non-working gh action lying around. I like it even less if we enable it and ignore the result.
The third option is also not so great as we will simply forget about this.
The second option is also not great but seems like the best of all possible solutions. I'll go for that

@egli egli marked this pull request as draft February 27, 2025 15:36
@egli egli removed this from the 3.33 milestone Feb 27, 2025
@egli egli removed their assignment Feb 27, 2025
@bertfrees

Copy link
Copy Markdown
Member

OK for me

@LeonarddeR

Copy link
Copy Markdown
Member Author

That's fine

@bertfrees bertfrees added the blocked Blocked on another issue label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Blocked on another issue build system Anything related to Autotools, the Windows build, CI, Fuzz, etc. needs fixup Branch needs cleaning up before it's merged. Don't press any buttons! windows Related to Microsoft Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants