lscm: fix sign for the area term#1853
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Jul 20, 2021
Merged
Conversation
Collaborator
|
Nice! Could you write your test function as a unit test in the PR? |
Added an overload where the matrix Q can be returned (used in the test).
Contributor
Author
|
@jdumas |
alecjacobson
approved these changes
Jul 20, 2021
factoryofthesun
added a commit
to factoryofthesun/libigl
that referenced
this pull request
Jul 28, 2021
The fix in libigl#1853 causes the solution UVs to be flipped, so this is a simple fix to that.
4 tasks
kenshi84
pushed a commit
to kenshi84/libigl
that referenced
this pull request
Mar 21, 2022
The fix in libigl#1853 causes the solution UVs to be flipped, so this is a simple fix to that.
alecjacobson
pushed a commit
that referenced
this pull request
Oct 2, 2022
The fix in #1853 causes the solution UVs to be flipped, so this is a simple fix to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this fix is correct -- the area term should be subtracted, not added.
To confirm the correctness, I wrote the following code
and put the following code
after the call to
min_quad_with_fixed_solve.Before the fix:
After the fix:
Checklist