lscm: fix order of UV after area term sign fix#1863
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Oct 2, 2022
Merged
Conversation
The fix in libigl#1853 causes the solution UVs to be flipped, so this is a simple fix to that.
kenshi84
approved these changes
Mar 20, 2022
Contributor
|
lol, so the git blame shows that this line has been toggled before e4876bd What's the real issue here? Isn't LSCM orientation determined by the boundary conditions? If so, why should this method flip the output? If my understanding is correct then I'm inclined to merge this PR (and revert back to the original code!), but it'd be nice to be sure that the intent. |
Contributor
I don't think fixing two boundary vertices will determine the orientation of triangles. My guessed logical explanation is that by using the wrong sign (+ instead of -) of the area term, the wrong LSCM energy wanted to make all the triangles flipped (i.e. to make their areas negative). |
alecjacobson
approved these changes
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #1853 causes the solution UVs to be flipped, so this is a simple fix to that.
See attached a parameterization of an example surface. Apologies in advance for no reproducible example code in C -- I've been working with the python bindings and whipped this up on short notice.
Checklist