Conversation
|
I've no idea wtf is up with travis. It looks like the test suite is failing to copy over the test resources. |
There was a problem hiding this comment.
Should we be more defensive here? strchr may return a null pointer.
There was a problem hiding this comment.
If something like that happens, we're screwed either way, because the config machinery is giving us complete nonsense back.
There was a problem hiding this comment.
I'd rather return a NULL than segfault. If you're assuming that the config variable will have a ., then assert it.
|
Travis has been failing a lot but I don't think we've performed any changes in the suite lately. Let me ask the Travis CI guys... |
|
It's only the third one down which fails, something about not being able to copy files... really odd. |
This should make it more readable and allocate a bunch fewer strings.
When we delete a remote, we also need to go through its fetch refspecs and remove the references they create locally.
|
Anything else here? The source of travis failures was fixed. |
|
I like it. :D |
Remote deletion
This is based off of #1199
It's been a long time coming, but here's a version of
git_remote_delete()that performs all of the steps.