Skip to content

WIP - Add git_remote_delete()#1199

Closed
nulltoken wants to merge 2 commits intolibgit2:developmentfrom
nulltoken:topic/remote-delete
Closed

WIP - Add git_remote_delete()#1199
nulltoken wants to merge 2 commits intolibgit2:developmentfrom
nulltoken:topic/remote-delete

Conversation

@nulltoken
Copy link
Member

No description provided.

@vmg
Copy link
Member

vmg commented Nov 14, 2013

@carlosmn: has this been superseded?

@carlosmn
Copy link
Member

A bunch of this made its way into the library, but we still don't have a git_remote_delete().

@vmg
Copy link
Member

vmg commented Nov 14, 2013

Whelp then. Paging doctor @nulltoken, care to rebase and cleanup this? :)

@nulltoken
Copy link
Member Author

@vmg Rebased and cleaned up!

One feature is still not implemented though.

Two unrelated commits have been removed from this PR pushed into separate ones (#1963 and #1964)

@vmg
Copy link
Member

vmg commented Nov 15, 2013

Travis is not happy. :)

@carlosmn throw a couple eyes on this please ^^

@nulltoken
Copy link
Member Author

Travis is not happy. :)

This is because of the missing feature

void test_network_remote_delete__deleting_a_remote_removes_the_remote_tracking_references(void)
{
    cl_assert(false);
}

@carlosmn
Copy link
Member

The part that's implemented looks fine, though we should move it over to the config iterators instead of callbacks. We should also add tests to make sure we do whatever git does when the fetch refspec isn't the default one.

@arthurschreiber
Copy link
Member

@nulltoken Are you planning to work on this? If not, I might look into cleaning this up. I want to improve my C-fu a bit and am looking for simpler things in the project that I could work on.

@nulltoken
Copy link
Member Author

@arthurschreiber Go for it. AFAIR the failing tests were pointing at what was missing from the feature perspective.

@ben ben mentioned this pull request Feb 24, 2014
34 tasks
@carlosmn carlosmn mentioned this pull request Apr 30, 2014
@carlosmn
Copy link
Member

Functionality added in #2313

@carlosmn carlosmn closed this May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants