Skip to content

config: Enhance config_rename_section error handling#1964

Closed
nulltoken wants to merge 1 commit intodevelopmentfrom
ntk/topic/config_rename_better_error
Closed

config: Enhance config_rename_section error handling#1964
nulltoken wants to merge 1 commit intodevelopmentfrom
ntk/topic/config_rename_better_error

Conversation

@nulltoken
Copy link
Member

Improved error messages

/cc @ethomson

@arrbee
Copy link
Member

arrbee commented Nov 15, 2013

So, I actually think this is the type of error handling changes that we don't want to make. These errors are already being reported by earlier code and this just overwrites the initial error with a new one. We used to do this, but our policy has been not to. I'm curious if this is the type if fix that @ethomson was looking for?

@ethomson
Copy link
Member

It's not what I was talking about, no. This feels orthogonal to what I was talking about.

Is the error message before this PR very bad? (Sorry, I don't have the code in front of me.)

@nulltoken
Copy link
Member Author

@arrbee This commit is 10 months old or so and has been cherry picked while #1199 was being rebased. I was more or less expecting this reaction, this is what I pushed it separately ;-)

Closing.

@nulltoken nulltoken closed this Nov 15, 2013
@ethomson ethomson deleted the ntk/topic/config_rename_better_error branch January 9, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants