config: Enhance config_rename_section error handling#1964
Closed
nulltoken wants to merge 1 commit intodevelopmentfrom
Closed
config: Enhance config_rename_section error handling#1964nulltoken wants to merge 1 commit intodevelopmentfrom
nulltoken wants to merge 1 commit intodevelopmentfrom
Conversation
Member
|
So, I actually think this is the type of error handling changes that we don't want to make. These errors are already being reported by earlier code and this just overwrites the initial error with a new one. We used to do this, but our policy has been not to. I'm curious if this is the type if fix that @ethomson was looking for? |
Member
|
It's not what I was talking about, no. This feels orthogonal to what I was talking about. Is the error message before this PR very bad? (Sorry, I don't have the code in front of me.) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved error messages
/cc @ethomson