Skip to content

Conversation

@tiennou
Copy link
Contributor

@tiennou tiennou commented Sep 16, 2013

That was originally discussed in #1706.

I'm having a hard time debugging libgit2/objective-git#254 and the weirdness in what cred object libssh2 needs to authenticate, so that'll help.

@vmg
Copy link
Member

vmg commented Sep 16, 2013

Thanks! The SSH error wrapper looks nice, but we favor 0 and -1 instead of the explicit error codes, because of convention. Can you drop that commit?

@tiennou
Copy link
Contributor Author

tiennou commented Sep 16, 2013

Np. Even the LIBSSH2_ERROR_NONE ones ?

@tiennou
Copy link
Contributor Author

tiennou commented Sep 16, 2013

Rebased and kept only the libssh2 defines.

vmg pushed a commit that referenced this pull request Sep 17, 2013
Provide libssh2 error message
@vmg vmg merged commit 38fba83 into libgit2:development Sep 17, 2013
@vmg
Copy link
Member

vmg commented Sep 17, 2013

:D

phatblat pushed a commit to phatblat/libgit2 that referenced this pull request Sep 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants