Also also, I'm somewhat saddened about the "useless" error reporting (since I come here while trying to add remote fetching to Objective-Git). Would it be possible to have more meaningful error codes ?

I'm not super familiar with this code, so I'd been hoping that someone with more knowledge of the networking code would comment. If no one else has been able to look at this by tomorrow, I'll dive in and check it out.

Are you talking about the NULL callback crash or the error reporting ? I'm happy to take a look and check that in that PR if you want.

✨ The new goto on_error seems like the right thing to do. There are only a couple very minor problems.

• The new goto jumps to returning -1 without setting an error message which will be confusing for the end user. It should probably read something like:

    } else {
        giterr_set(GITERR_NET, "Cannot set up SSH connection without credentials");
        goto on_error;
    }

• It seems like the indentation on that new goto statement doesn't match the code around it. Libgit2 uses tabs for indentation (I know, crazy!) so if you could fix it to match the other indentation and use tabs, that would be great.

🎧

Also includes some error messages for SSH connection failures. Would a wrapper around libssh2_session_last_error be useful for those ?

@tiennou Let's get this merged first, but I do like the idea of wrapping libssh2_session_last_error to get better error information.

Thanks @tiennou ! If you want to go further with the libssh2_session_last_error idea, I'd be happy to see that.