fix: switch how we do http requests to fix socket disconnect error#197
fix: switch how we do http requests to fix socket disconnect error#197levibostian merged 1 commit intomainfrom
Conversation
This keeps happening on decaf and cathy's CI... 🔄 Verifying that the new release was created by re-running the get-latest-release step... I will set the git committer config to the user provided values: name: github-actions[bot], email: 41898282+github-actions[bot]@users.noreply.github.com $> deno run --allow-all --quiet jsr:@levibostian/decaf-script-github-releases get Latest git tag on the current branch is: 0.5.1 latest release found: 0.5.1 (0.5.1) commit matching release found: fix: attach readme to the deno module. because, you know, you need docs (#8) (44b0c3d0915014aa925a2c5fbe91329278f6abf2) Warning:⚠️ Verification failed, but that could be expected in test mode. The latest release after deployment is 0.5.1, but expected 0.6.0. This could indicate a problem with the deployment process. 🎉 Congratulations! The deployment process has completed. Bye-bye 👋! error: Uncaught (in promise) Error: socket hang up at connResetException (ext:deno_node/internal/errors.ts:1969:14) at node:http:512:30 this is an attempt to fix it
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🚢 The next version of the project will be: 2.0.1 Learn moreLatest release: 2.0.0 Commit of latest release: 5bfdd17 Commits since last release: - fix: switch how we do http requests to fix socket disconnect error Related GitHub Issues<!-- Link to any related GitHub issues that this pull request addresses or closes. --> Problem<!-- A clear description of the problem that this pull request is solving. --> This keeps happening on decaf and cathy's CI... Solution<!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> Something about node:http and connection pools makes this error somewhat common. Switching to Testing<!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. -->
Notes for reviewers<!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. --> Bumps the github-action-dependencies group with 2 updates: Updates Release notesSourced from actions/checkout's releases.
... (truncated) ChangelogSourced from actions/checkout's changelog.
... (truncated) Commits
Updates Release notesSourced from denoland/setup-deno's releases.
... (truncated) Commits
Dependabot will resolve any conflicts with this PR as long as you don't Dependabot commands and optionsYou can trigger Dependabot actions by commenting on this PR:
Signed-off-by: dependabot[bot] support@github.com |
## Related GitHub Issues <!-- Link to any related GitHub issues that this pull request addresses or closes. --> ## Problem <!-- A clear description of the problem that this pull request is solving. --> levibostian/cathy#197 ## Solution <!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> Install cathy 2.0.1 ## Testing <!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. --> - [ ] Added automated tests. - [X] Manually tested. If you check this box, provide instructions for others to test, too. I'll be creating a binary and testing it out in some projects of mine ## Notes for reviewers <!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. -->
Related GitHub Issues
Problem
This keeps happening on decaf and cathy's CI...
Solution
Something about node:http and connection pools makes this error somewhat common. Switching to
fetchis supposed to address it. I need a http solution that works on deno, bun, node.Testing
Notes for reviewers