Conversation
kt3k
reviewed
Jul 12, 2024
src/version.js
Outdated
| "Failed to fetch release version info from dl.deno.land. Please try again later.", | ||
| ); | ||
| } | ||
| const version = (await res.text()).trim(); |
Contributor
There was a problem hiding this comment.
I wonder if we need to call version = semver.clean(version); like the below path. That seems stripping the leading v
Contributor
There was a problem hiding this comment.
Ah, probably we need to call semver.clean() to strip the leading v because v is prepended later here https://github.com/denoland/setup-deno/blob/main/src/install.js#L24
Member
Author
There was a problem hiding this comment.
yes, good catch. fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To bypass a circular need of having the latest version during release, this bypasses dotcom's versions.json and instead uses https://dl.deno.land/release-latest.txt