Use GitHub Actions#442
Merged
Merged
Conversation
aarongable
previously approved these changes
Feb 26, 2024
aarongable
left a comment
Contributor
There was a problem hiding this comment.
Thank you so much! This looks essentially good to me and I'd honestly be okay landing it as-is because it's just an improvement over the status quo, but I do have a few suggestions for further improvements as well. Thanks!
Merged
Contributor
Author
|
I didn't dismiss your review 🤔 |
Contributor
|
Pushing a commit dismisses the review (this is configurable in GH) |
Contributor
Author
|
I think I fixed everything. |
mcpherrinm
approved these changes
Feb 26, 2024
Contributor
|
Thanks! This is a pretty significant improvement. We can definitely merge this and continue to improve from here. |
aarongable
approved these changes
Feb 27, 2024
mcpherrinm
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mages (#444) [](https://github.com/fastly/pebble/actions/workflows/checks.yml) [](https://github.com/fastly/pebble/actions/workflows/tests.yml) As a follow-on to #439 this change request implements the first step of building a new CI system for Pebble. As this is a testbed environment for Boulder, some of these changes may prove to be useful in the latter context. Per #434 (comment), GitHub Actions is a reasonable choice for a new CI implementation to supersede Travis. Much, but not all, of the existing functionality is present in this initial set of changes. Items currently implemented include: - Binary production of `pebble` and `challtestsrv` for platforms: - AMD64 - darwin - linux - windows - ARM64 - darwin - linux - windows - Multiplatform docker images published on the GitHub Container Registry for platforms: - linux/amd64 - linux/arm64 - windows/amd64 - Golang linting. - Golang coverage. - Local test scripts for Go and Docker: - `./build.sh` - `./docker.sh` - `./test.sh` This PR also adds a `-version` flag to Pebble, which is set during release build to the Git commit ref. This change builds on earlier work done in #379 and #442.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I know there is a current open PR on the topic, but there has been no move for a long time, and it feels more like a WIP than a mergeable PR.
I just added the basics:
Please consider it as a first step (it's better than no CI 😸).
I didn't add a workflow on Windows because the current Appveyor setup file is not Linux user-friendly.
But I can spend time on it later and create a specific PR.
I don't add the release part, I want to discuss it because it's not a simple step.
You can take a look at the CI of my fork if needed: https://github.com/ldez/pebble/actions
Fixes #356
Closes #379
Note: the PR #441 should be merged first.