GolangCI-Lint Fixes#439
Merged
Merged
Conversation
Closed
Contributor
Author
|
I've identified a concurrency race condition related to this patch and will be providing a fix shortly: |
Contributor
Author
|
Corrected the race condition in |
Merged
aarongable
previously approved these changes
Feb 26, 2024
aarongable
left a comment
Contributor
There was a problem hiding this comment.
Go code changes LGTM. Travis / Appveyor changes seem reasonable but I know nothing about those systems and with #442 it looks like we're heading towards getting rid of them.
43fb632 to
7ccbbc3
Compare
Contributor
Author
|
@aarongable this change is ready for re-approval after merging main. |
mcpherrinm
approved these changes
Feb 27, 2024
mcpherrinm
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mages (#444) [](https://github.com/fastly/pebble/actions/workflows/checks.yml) [](https://github.com/fastly/pebble/actions/workflows/tests.yml) As a follow-on to #439 this change request implements the first step of building a new CI system for Pebble. As this is a testbed environment for Boulder, some of these changes may prove to be useful in the latter context. Per #434 (comment), GitHub Actions is a reasonable choice for a new CI implementation to supersede Travis. Much, but not all, of the existing functionality is present in this initial set of changes. Items currently implemented include: - Binary production of `pebble` and `challtestsrv` for platforms: - AMD64 - darwin - linux - windows - ARM64 - darwin - linux - windows - Multiplatform docker images published on the GitHub Container Registry for platforms: - linux/amd64 - linux/arm64 - windows/amd64 - Golang linting. - Golang coverage. - Local test scripts for Go and Docker: - `./build.sh` - `./docker.sh` - `./test.sh` This PR also adds a `-version` flag to Pebble, which is set during release build to the Git commit ref. This change builds on earlier work done in #379 and #442.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #438 by fixing all of the reported issues in Pebble code.
When run with the default lint configuration, golangci-lint reports:
These errors are addressed here.
Other fixes include: