Skip to content

ratelimits: Skip Spends on CertificatesPerDomain for renewals#7676

Merged
beautifulentropy merged 3 commits into
mainfrom
ratelimits-ra-isrenewal
Aug 21, 2024
Merged

ratelimits: Skip Spends on CertificatesPerDomain for renewals#7676
beautifulentropy merged 3 commits into
mainfrom
ratelimits-ra-isrenewal

Conversation

@beautifulentropy

@beautifulentropy beautifulentropy commented Aug 21, 2024

Copy link
Copy Markdown
Member

This bug was introduced in #7669.

Also, make calls to ra.countCertificateIssued() non-blocking like ra.countFailedValidation().

Part of #7664
Blocks #7666

@beautifulentropy beautifulentropy marked this pull request as ready for review August 21, 2024 16:38
@beautifulentropy beautifulentropy requested a review from a team as a code owner August 21, 2024 16:38
aarongable
aarongable previously approved these changes Aug 21, 2024
Comment thread ra/ra.go Outdated
@beautifulentropy beautifulentropy merged commit 4bf6e2f into main Aug 21, 2024
@beautifulentropy beautifulentropy deleted the ratelimits-ra-isrenewal branch August 21, 2024 19:25
beautifulentropy added a commit that referenced this pull request Aug 22, 2024
…uthoritative (#7666)

- Add feature flag `UseKvLimitsForNewOrder`
- Add feature flag `UseKvLimitsForNewAccount`
- Flush all Redis shards before running integration or unit tests, this
avoids false positives between local testing runs

Fixes #7664
Blocked by #7676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants