ratelimits: Check at NewOrder and SpendOnly later#7669
Merged
Conversation
73ed05b to
315ab1a
Compare
315ab1a to
e9ee493
Compare
e9ee493 to
08170d7
Compare
aarongable
previously approved these changes
Aug 15, 2024
aarongable
previously approved these changes
Aug 15, 2024
Contributor
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
approved these changes
Aug 15, 2024
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM % filing a ticket for the RA to be hooked up to the rate limits redis cluster
Member
Author
Filing a ticket with #7666 to ensure that the RA gets hooked up and I'll ensure that there's no dependence on it unless it's configured and the flag is flipped. |
beautifulentropy
added a commit
that referenced
this pull request
Aug 16, 2024
- Check `CertificatesPerDomain` at newOrder and spend at Finalize time. - Check `CertificatesPerAccountPerDomain` at newOrder and spend at Finalize time. - Check `CertificatesPerFQDNSet` at newOrder and spend at Finalize time. - Fix a bug in`FailedAuthorizationsPerDomainPerAccountSpendOnlyTransaction()` which results in failed authorizations being spent for the exact FQDN, not the eTLD+1. - Remove redundant "max names" check at transaction construction time - Enable key-value rate limits in the RA
This was referenced Aug 16, 2024
beautifulentropy
added a commit
that referenced
this pull request
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CertificatesPerDomainat newOrder and spend at Finalize time.CertificatesPerAccountPerDomainat newOrder and spend at Finalize time.CertificatesPerFQDNSetat newOrder and spend at Finalize time.FailedAuthorizationsPerDomainPerAccountSpendOnlyTransaction()which results in failed authorizations being spent for the exact FQDN, not the eTLD+1.