Skip to content

redis: Add support for *redis.Ring shard configuration using SRV records#7042

Merged
beautifulentropy merged 12 commits into
mainfrom
shard-discovery-via-srv
Sep 11, 2023
Merged

redis: Add support for *redis.Ring shard configuration using SRV records#7042
beautifulentropy merged 12 commits into
mainfrom
shard-discovery-via-srv

Conversation

@beautifulentropy

@beautifulentropy beautifulentropy commented Aug 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #5545

@beautifulentropy beautifulentropy mentioned this pull request Aug 18, 2023
Merged
@beautifulentropy beautifulentropy changed the base branch from main to update-go-redis August 18, 2023 15:11
@beautifulentropy beautifulentropy marked this pull request as ready for review August 18, 2023 15:13
@beautifulentropy beautifulentropy requested a review from a team as a code owner August 18, 2023 15:13
@beautifulentropy beautifulentropy requested review from a team, aarongable, jsha and pgporada and removed request for a team August 18, 2023 15:13
@beautifulentropy beautifulentropy mentioned this pull request Aug 15, 2023
Closed
18 tasks
@beautifulentropy beautifulentropy removed the request for review from jsha August 18, 2023 15:26
pgporada
pgporada reviewed Aug 22, 2023
View reviewed changes
Comment thread redis/lookup.go
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Base automatically changed from update-go-redis to main August 22, 2023 17:06
beautifulentropy added a commit that referenced this pull request Aug 22, 2023
@beautifulentropy
dependencies: Update go-redis from v8 to v9 (#7041)
4ed54ff 
Updated so we can access the `SetAddrs()` method added to `*redis.Ring`
in `v9` in #7042.

Part of #5545
pgporada
pgporada previously approved these changes Aug 22, 2023
View reviewed changes
@beautifulentropy beautifulentropy marked this pull request as draft August 22, 2023 21:58
@beautifulentropy beautifulentropy force-pushed the shard-discovery-via-srv branch from 74db869 to f41e2c8 Compare August 23, 2023 21:33
@beautifulentropy beautifulentropy marked this pull request as ready for review August 23, 2023 21:34
@aarongable

aarongable commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Can you add a merge commit to this that brings in the changes from #7041? It'll make this easier to review.

aarongable
aarongable reviewed Aug 25, 2023
View reviewed changes
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup_test.go Outdated
Comment thread redis/lookup_test.go Outdated
Comment thread redis/lookup_test.go Outdated
@beautifulentropy beautifulentropy force-pushed the shard-discovery-via-srv branch from c8da356 to 5d6c3c7 Compare August 30, 2023 20:17
@beautifulentropy beautifulentropy marked this pull request as draft August 30, 2023 21:10
@beautifulentropy beautifulentropy marked this pull request as ready for review August 30, 2023 21:39
aarongable
aarongable reviewed Aug 31, 2023
View reviewed changes
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup.go
Comment thread redis/lookup.go Outdated
Comment thread redis/lookup_test.go Outdated
Comment thread redis/lookup_test.go Outdated
Comment thread redis/lookup_test.go Outdated
aarongable
aarongable approved these changes Sep 7, 2023
View reviewed changes
Comment thread redis/lookup.go
Comment thread redis/lookup.go
@beautifulentropy beautifulentropy merged commit 7068db9 into main Sep 11, 2023
@beautifulentropy beautifulentropy deleted the shard-discovery-via-srv branch September 11, 2023 19:06
@beautifulentropy beautifulentropy mentioned this pull request Sep 14, 2023
Merged
beautifulentropy added a commit that referenced this pull request Sep 14, 2023
@beautifulentropy
redis: Small Lookup cleanup (#7084)
b17123c 
Small changes left over from #7042
This was referenced Sep 18, 2023
Open
Merged
beautifulentropy added a commit that referenced this pull request Oct 4, 2023
@beautifulentropy
WFE: Add new key-value ratelimits implementation (#7089)
9aef583 
Integrate the key-value rate limits from #6947 into the WFE. Rate limits
are backed by the Redis source added in #7016, and use the SRV record
shard discovery added in #7042.

Part of #5545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgporada pgporada pgporada approved these changes

@aarongable aarongable aarongable approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beautifulentropy @aarongable @pgporada