Skip to content

ratelimits: Add Redis source#7016

Merged
beautifulentropy merged 4 commits into
mainfrom
rate-limts-redis-source
Aug 10, 2023
Merged

ratelimits: Add Redis source#7016
beautifulentropy merged 4 commits into
mainfrom
rate-limts-redis-source

Conversation

@beautifulentropy

@beautifulentropy beautifulentropy commented Jul 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #5545

@beautifulentropy beautifulentropy force-pushed the rate-limts-redis-source branch from 14f26e5 to fc3967f Compare July 31, 2023 17:36
@beautifulentropy beautifulentropy force-pushed the rate-limts-redis-source branch from fc3967f to 0b7a0d1 Compare July 31, 2023 17:51
@beautifulentropy beautifulentropy marked this pull request as ready for review July 31, 2023 18:15
@beautifulentropy beautifulentropy requested a review from a team as a code owner July 31, 2023 18:15
@beautifulentropy beautifulentropy requested a review from jsha July 31, 2023 18:15
jsha
jsha requested changes Aug 2, 2023
View reviewed changes

@jsha jsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like the test coverage.

Comment thread docker-compose.yml Outdated
Comment thread ratelimits/source-redis.go
Comment thread ratelimits/source-redis.go Outdated
Comment thread ratelimits/source-redis_test.go Outdated
Comment thread ratelimits/source-redis_test.go Outdated
Comment thread ratelimits/source-redis_test.go Outdated
aarongable
aarongable reviewed Aug 3, 2023
View reviewed changes
Comment thread ratelimits/source-redis.go
Comment thread ratelimits/source-redis.go
Comment thread ratelimits/source-redis_test.go Outdated
Comment thread ratelimits/source-redis_test.go Outdated
@beautifulentropy beautifulentropy mentioned this pull request Aug 8, 2023
Closed
18 tasks
aarongable
aarongable previously approved these changes Aug 9, 2023
View reviewed changes
Comment thread ratelimits/limiter_test.go Outdated
Comment thread ratelimits/limiter_test.go
@beautifulentropy

beautifulentropy commented Aug 9, 2023

Copy link
Copy Markdown
Member Author

Thanks for all of the lovely suggestions @aarongable @jsha. I'm really happy with how this addition turned out.

@beautifulentropy beautifulentropy merged commit 48f211c into main Aug 10, 2023
@beautifulentropy beautifulentropy deleted the rate-limts-redis-source branch August 10, 2023 15:45
@beautifulentropy beautifulentropy mentioned this pull request Sep 18, 2023
Merged
beautifulentropy added a commit that referenced this pull request Oct 4, 2023
@beautifulentropy
WFE: Add new key-value ratelimits implementation (#7089)
9aef583 
Integrate the key-value rate limits from #6947 into the WFE. Rate limits
are backed by the Redis source added in #7016, and use the SRV record
shard discovery added in #7042.

Part of #5545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsha jsha jsha approved these changes

@aarongable aarongable aarongable approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beautifulentropy @jsha @aarongable