Install v2.20.0 of docker-compose-plugin#6997
Merged
Merged
Conversation
jsha
reviewed
Jul 13, 2023
|
|
||
| # TODO(#6998): Remove this step. | ||
| - name: Update docker compose plugin | ||
| run: mkdir -p ${DOCKER_CONFIG:-$HOME/.docker}/cli-plugins && curl -SL https://github.com/docker/compose/releases/download/v2.20.0/docker-compose-linux-x86_64 -o ${DOCKER_CONFIG:-$HOME/.docker}/cli-plugins/docker-compose && chmod +x ${DOCKER_CONFIG:-$HOME/.docker}/cli-plugins/docker-compose |
Contributor
There was a problem hiding this comment.
Can you link to some documentation on what the cli-plugins directory does? Also this looks like the command is copy-pasted from somewhere, which is fine, but we should link to it.
Contributor
Author
There was a problem hiding this comment.
They're from https://docs.docker.com/compose/install/linux/#install-the-plugin-manually. Comment updated. The cli-plugins directory is just a place where the docker command looks for executables that it can expose as subcommands, much like git searches $PATH for executables named git-something and exposes them as git something subcommands.
jsha
approved these changes
Jul 13, 2023
pgporada
approved these changes
Jul 13, 2023
aarongable
added a commit
that referenced
this pull request
Aug 1, 2023
This reverts commit 944a865.
pgporada
pushed a commit
that referenced
this pull request
Aug 2, 2023
Reverts #6997, which manually installed a specific version of the docker compose cli plugin to work around a bug in the version installed by default. The images now ship the fixed version by default (actions/runner-images#7916 (comment)), so we can remove the workaround. Fixes #6998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around the bug[1] in docker-compose-plugin v2.19.1, which is included in the current github actions ubuntu 20.04 runner image[2].
[1] docker/compose#10777
[2] actions/runner-images#7916
Part of #6998