Skip to content

Add onlyExplicitUpdates flag so that only packages that have change…#241

Merged
hzoo merged 1 commit intomasterfrom
explicit-updates-only
Jun 24, 2016
Merged

Add onlyExplicitUpdates flag so that only packages that have change…#241
hzoo merged 1 commit intomasterfrom
explicit-updates-only

Conversation

@hzoo
Copy link
Copy Markdown
Contributor

@hzoo hzoo commented Jun 22, 2016

…d have version bumps rather than all packages that depend on the updated packages

Just picked a name

Ref #240

Doing this for backwards compat with how Babel has been released but maybe we don't want to do this?

cc @thejameskyle @loganfsmyth

@hzoo hzoo force-pushed the explicit-updates-only branch 2 times, most recently from 86e3b17 to 993cdef Compare June 22, 2016 20:50

#### --onlyExplicitUpdates

Only will bump versions for packages that have been updated explicitly rather than cross-dependencies.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth including a warning against using this with a major version bump.

@hzoo hzoo force-pushed the explicit-updates-only branch from 993cdef to 25b5e62 Compare June 23, 2016 01:09
@gigabo
Copy link
Copy Markdown
Contributor

gigabo commented Jun 23, 2016

Makes sense. I'll use it. What I'd really like is for this to be the default behavior for semver-compatible version bumps, but I guess that's tricky... especially with --independent. 😬

@hzoo hzoo force-pushed the explicit-updates-only branch from 25b5e62 to e2540cb Compare June 23, 2016 14:14
…d have version bumps rather than all packages that depend on the updated packages
@hzoo hzoo force-pushed the explicit-updates-only branch from e2540cb to a3d4ae1 Compare June 23, 2016 14:28
@hzoo
Copy link
Copy Markdown
Contributor Author

hzoo commented Jun 24, 2016

Yeah we can talk about doing it by default later

@hzoo hzoo merged commit bc11eaa into master Jun 24, 2016
@hzoo hzoo deleted the explicit-updates-only branch June 24, 2016 18:18
@jamiebuilds
Copy link
Copy Markdown
Contributor

This is more complex. If you have a package that gets a major bump and its dependents don't get bumped as well then they are no longer linked packages because they don't satisfy semver ranges.

I would revert this until everything is covered

@hzoo
Copy link
Copy Markdown
Contributor Author

hzoo commented Jun 27, 2016

Yeah that is an issue with non-independent mode in general since bumping 1 package means all packages will need to be updated to major version in the next update?

LoicMahieu added a commit to LoicMahieu/lerna that referenced this pull request Jun 28, 2016
* feature/pkg-main:
  Bootstrap: copy `main` property from package.json
  2.0.0-beta.23
  fix execSync use
  Add `onlyExplicitUpdates` flag so that only packages that have changed have version bumps rather than all packages that depend on the updated packages (lerna#241)
  Re-introduce node 0.10 support (lerna#248)
  2.0.0-beta.22
  Consistent naming in README `import` section (lerna#243) [skip ci]
  Lerna import (lerna#173)
  Revert "Use sync-exec for node 0.10" (lerna#242)
  Revert "Fix bootstrap install to use quotes around versions (lerna#235)"
  2.0.0-beta.21
  Fix bootstrap install to use quotes around versions (lerna#235)
  typo [skip ci]

# Conflicts:
#	src/commands/BootstrapCommand.js
rygine pushed a commit to awakesecurity/lerna that referenced this pull request Jun 28, 2016
…d have version bumps rather than all packages that depend on the updated packages (lerna#241)
@jamiebuilds
Copy link
Copy Markdown
Contributor

I think that is an issue regardless, I think it's best we just force all packages to be published to avoid weird states

@lock
Copy link
Copy Markdown

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants