Fix bootstrap install to use quotes around versions#235
Merged
jamiebuilds merged 2 commits intomasterfrom Jun 20, 2016
Merged
Conversation
src/commands/BootstrapCommand.js
Outdated
| }) | ||
| .map(dependency => { | ||
| return dependency + "@" + allDependencies[dependency]; | ||
| return dependency + "@\"" + allDependencies[dependency] + "\""; |
Contributor
There was a problem hiding this comment.
This is getting into the range where a template string might be more readable:
return `${dependency}@"${allDependencies[dependency]}"`;
Contributor
There was a problem hiding this comment.
Could leave a comment of an example package version of why it needs the quotes
jamiebuilds
added a commit
that referenced
this pull request
Jun 21, 2016
This reverts commit c0f1e8d.
LoicMahieu
added a commit
to LoicMahieu/lerna
that referenced
this pull request
Jun 28, 2016
* feature/pkg-main: Bootstrap: copy `main` property from package.json 2.0.0-beta.23 fix execSync use Add `onlyExplicitUpdates` flag so that only packages that have changed have version bumps rather than all packages that depend on the updated packages (lerna#241) Re-introduce node 0.10 support (lerna#248) 2.0.0-beta.22 Consistent naming in README `import` section (lerna#243) [skip ci] Lerna import (lerna#173) Revert "Use sync-exec for node 0.10" (lerna#242) Revert "Fix bootstrap install to use quotes around versions (lerna#235)" 2.0.0-beta.21 Fix bootstrap install to use quotes around versions (lerna#235) typo [skip ci] # Conflicts: # src/commands/BootstrapCommand.js
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234