[Merged by Bors] - refactor(Data/Rat/NNRat): move module and algebra instances#9951
Closed
eric-wieser wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Data/Rat/NNRat): move module and algebra instances#9951eric-wieser wants to merge 7 commits intomasterfrom
eric-wieser wants to merge 7 commits intomasterfrom
Conversation
We already have the instances for `ℕ`, `ℤ`, and `ℚ` in this file, so adding `NNRat` doesn't feel that out of place.
eric-wieser
commented
Jan 24, 2024
| Authors: Yaël Dillies, Bhavik Mehta | ||
| -/ | ||
| import Mathlib.Algebra.Algebra.Basic | ||
| import Mathlib.Algebra.Function.Indicator |
Member
Author
There was a problem hiding this comment.
Removing this would remove another 30 or so dependencies, but I'm declaring that a problem for a follow-up. I think further reduction probably entails splitting this file.
Contributor
There was a problem hiding this comment.
Note that I already reduced the dependencies of Algebra.Function.Indicator by quite a lot because of this.
1 task
Contributor
|
I just noticed that maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
Author
Only before this PR though, right? |
Contributor
Actually, this spurious dependency was introduced in #9950. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
Contributor
|
Build failed (retrying...):
|
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
Contributor
|
Build failed: |
Member
Author
Contributor
Member
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
As with #9950, this is motivated by: * Getting `NNRat` closed to `norm_num` * Being able to put an `nnrat_cast` field in `DivisionSemiring`s This brings down the number of dependencies of `NNRat` by around 600.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with #9950, this is motivated by:
NNRatclosed tonorm_numnnrat_castfield inDivisionSemiringsThis brings down the number of dependencies of
NNRatby around 600.Archimedeaninstances toOrder/Archimedean#9950The graph is still a monster: