Skip to content

[Merged by Bors] - refactor(Order/CompleteLatticeIntervals): move lemmas with a multiset dependency to a new file#10165

Closed
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/compact-intervals
Closed

[Merged by Bors] - refactor(Order/CompleteLatticeIntervals): move lemmas with a multiset dependency to a new file#10165
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/compact-intervals

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Feb 1, 2024

This reworks the location of the lemmas from #10086, by moving them to a new Mathlib.Order.CompactlyGenerated.Intervals file.
The existing Mathlib.Order.CompactlyGenerated is moved to Mathlib.Order.CompactlyGenerated.Basic for consistency.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Feb 1, 2024
@eric-wieser eric-wieser requested a review from ocfnash February 1, 2024 17:12
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this.

I suggest going one step further and also replacing Mathlib.Order.CompactlyGenerated with Mathlib.Order.CompactlyGenerated.Basic.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 1, 2024

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Feb 1, 2024
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Feb 1, 2024

@eric-wieser if you like you can give the "auto-merge-after-CI" label a whirl here.

@eric-wieser eric-wieser changed the title refactor: move lemmas with a multiset dependency to a new file refactor(Order/CompleteLatticeIntervals): move lemmas with a multiset dependency to a new file Feb 1, 2024
@eric-wieser eric-wieser added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Feb 1, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 1, 2024
@ghost
Copy link
Copy Markdown

ghost commented Feb 1, 2024

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 1, 2024
… dependency to a new file (#10165)

This reworks the location of the lemmas from #10086, by moving them to a new `Mathlib.Order.CompactlyGenerated.Intervals` file.
The existing `Mathlib.Order.CompactlyGenerated` is moved to `Mathlib.Order.CompactlyGenerated.Basic` for consistency.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Order/CompleteLatticeIntervals): move lemmas with a multiset dependency to a new file [Merged by Bors] - refactor(Order/CompleteLatticeIntervals): move lemmas with a multiset dependency to a new file Feb 1, 2024
@mathlib-bors mathlib-bors bot closed this Feb 1, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/compact-intervals branch February 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants