Skip to content

[Merged by Bors] - chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat)#972

Closed
kim-em wants to merge 5 commits intomasterfrom
test_std_63
Closed

[Merged by Bors] - chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat)#972
kim-em wants to merge 5 commits intomasterfrom
test_std_63

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Dec 13, 2022

This verifies that leanprover-community/batteries#63 will work in mathlib4.

Before merging this:

@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 13, 2022
@kim-em kim-em added awaiting-review and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Dec 13, 2022
@kim-em kim-em changed the title chore: test that std4#63 will work chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) Dec 13, 2022
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Dec 13, 2022

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 13, 2022
bors bot pushed a commit that referenced this pull request Dec 13, 2022
This verifies that leanprover-community/batteries#63 will work in mathlib4.

Before merging this:
* [x] check that leanprover-community/batteries#63 has been merged
* [x] change `lakefile.lean` to point back to "main" for the std4 dependency
* [ ] we may want to golf the proofs where I have added `simp only [Int.ofNat_eq_coe]`, to combine these into the adjacent rw/simp.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Dec 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) [Merged by Bors] - chore: bump to get std4#63 (use Nat.cast in place of Int.ofNat) Dec 13, 2022
@bors bors bot closed this Dec 13, 2022
@bors bors bot deleted the test_std_63 branch December 13, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant