Conversation
This was referenced Dec 13, 2022
Closed
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 13, 2022
This verifies that leanprover-community/batteries#63 will work in mathlib4. Before merging this: * [x] check that leanprover-community/batteries#63 has been merged * [x] change `lakefile.lean` to point back to "main" for the std4 dependency * [ ] we may want to golf the proofs where I have added `simp only [Int.ofNat_eq_coe]`, to combine these into the adjacent rw/simp. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the
Nat.castfunction (without any lemmas, purely as notation), and changes the simp normal form ofInt.ofNattoNat.cast(with an appropriateNatCast Intinstance). We need to test that this works on mathlib4 before merging this.