Skip to content

[Merged by Bors] - chore: correct hypothesis order in dot notation lemma#9568

Closed
grunweg wants to merge 1 commit intomasterfrom
MR-mfderiv-dotnotation
Closed

[Merged by Bors] - chore: correct hypothesis order in dot notation lemma#9568
grunweg wants to merge 1 commit intomasterfrom
MR-mfderiv-dotnotation

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 8, 2024

Following a comment by @sgouezel, the hypothesis IsOpen s should be the first explicit argument.


@grunweg grunweg force-pushed the MR-mfderiv-dotnotation branch from 8dc18d9 to bc88df2 Compare January 8, 2024 23:08
@grunweg grunweg added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 8, 2024
@ghost ghost added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Jan 8, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 16, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jan 16, 2024

This PR/issue depends on:

@grunweg grunweg force-pushed the MR-mfderiv-dotnotation branch from bc88df2 to 7531ca3 Compare January 16, 2024 22:57
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 16, 2024
Copy link
Copy Markdown
Collaborator

@winstonyin winstonyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordering and style changes all seem straightforward and ready to merge.

@sgouezel
Copy link
Copy Markdown
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2024
Following a [comment](#8736 (comment)) by @sgouezel, the hypothesis `IsOpen s` should be the first explicit argument.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: correct hypothesis order in dot notation lemma [Merged by Bors] - chore: correct hypothesis order in dot notation lemma Jan 17, 2024
@mathlib-bors mathlib-bors bot closed this Jan 17, 2024
@mathlib-bors mathlib-bors bot deleted the MR-mfderiv-dotnotation branch January 17, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants