[Merged by Bors] - refactor(Geometry/Manifold/MFDeriv): split file#9565
Closed
[Merged by Bors] - refactor(Geometry/Manifold/MFDeriv): split file#9565
Conversation
A few drive-by changes which were almost necessary.
- the file docstring is almost entirely new (the old main docstring didn't
mention this at all),
- remove autoImplicit (just had to add one variable {x : M}),
- fix a few typos in docstrings --- just spelling or grammar.
into Atlas.lean as well.
…ate file. - The module docstring was partially present, but was incomplete. - Update the module docstring in Basic.lean for the moving, and indicate what the other files have now. - Make all my newly created files build: adjust imports for the further split.
- the module docstring was also mostly new (but easy to create) - the universe level was unused - implicit variables were only used once (hence removed)
1 task
Member
If you could do this: yes please! |
Contributor
Author
Split into #9588. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
To preserve most git history when splitting the file in #9565.
|
This PR/issue depends on:
|
Member
|
Thanks for performing this split! bors merge |
Contributor
|
Merge conflict. |
linesthatinterlace
pushed a commit
that referenced
this pull request
Jan 16, 2024
To preserve most git history when splitting the file in #9565.
Contributor
Author
|
bors r+ |
Contributor
|
🔒 Permission denied Existing reviewers: click here to make grunweg a reviewer |
Member
|
bors d+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
With about 2200 lines, this is the largest file in Geometry/Manifolds.
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
With about 2200 lines, this is the largest file in Geometry/Manifolds.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With about 2200 lines, this is the largest file in Geometry/Manifolds.
Can be reviewed commit by commit. (I adjusted imports later, but the substance of each commit stands on its own.)
This file was very well structured; this made splitting it much easier. Thanks to all the previous authors!
I'm open to splitting the moving of the main file into a separate commit (to preserve blame information better).
My apologies for sneaking in one dot notation change; it's hard to rebase it out now :-(
depends on: [Merged by Bors] - chore: move Geometry/Manifold/MFDeriv #9588