[Merged by Bors] - chore: Deprecate pow monotonicity lemmas#9235
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore: Deprecate pow monotonicity lemmas#9235YaelDillies wants to merge 3 commits intomasterfrom
YaelDillies wants to merge 3 commits intomasterfrom
Conversation
Add deprecated aliases for all the lemmas removed in #9095
eric-wieser
reviewed
Dec 23, 2023
Comment on lines
-178
to
+183
| theorem Monotone.pow_right {f : β → M} (hf : Monotone f) : ∀ n : ℕ, Monotone fun a => f a ^ n | ||
| theorem Monotone.pow_const {f : β → M} (hf : Monotone f) : ∀ n : ℕ, Monotone fun a => f a ^ n | ||
| | 0 => by simpa using monotone_const | ||
| | n + 1 => by | ||
| simp_rw [pow_succ] | ||
| exact hf.mul' (Monotone.pow_right hf _) | ||
| #align monotone.pow_right Monotone.pow_right | ||
| exact hf.mul' (Monotone.pow_const hf _) | ||
| #align monotone.pow_right Monotone.pow_const |
Member
There was a problem hiding this comment.
These don't look like deprecations to me; can you split them to their own PR?
Contributor
Author
There was a problem hiding this comment.
Those lemma renames were announced in #9095. I just messed up when doing so.
eric-wieser
reviewed
Dec 23, 2023
eric-wieser
reviewed
Dec 23, 2023
Member
|
LGTM but I don't know how to verify that all aliases are there. |
Contributor
Author
|
You could check the list from the description of #9095 one by one. I copy-pasted it to get the aliases. |
Member
|
Let's get it merged |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2023
Add deprecated aliases for all the lemmas removed in #9095 and fix a few renames that were botched.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deprecated aliases for all the lemmas removed in #9095 and fix a few renames that were botched.
See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Renaming.20monotonicity.20of.20powers.20lemmas