[Merged by Bors] - chore: Rename pow monotonicity lemmas#9095
Closed
YaelDillies wants to merge 13 commits intomasterfrom
Closed
[Merged by Bors] - chore: Rename pow monotonicity lemmas#9095YaelDillies wants to merge 13 commits intomasterfrom
YaelDillies wants to merge 13 commits intomasterfrom
Conversation
The names for lemmas about monotonicity of `(a ^ ·)` and `(· ^ n)` were a mess. This PR tidies up everything related by following the naming convention for `(a * ·)` and `(· * b)`. Namely, `(a ^ ·)` is `pow_right` and `(· ^ n)` is `pow_left` in lemma names. All lemma renames follow the corresponding multiplication lemma names closely. ## Renames ### `Algebra.GroupPower.Order` * `pow_mono` → `pow_right_mono` * `pow_le_pow` → `pow_le_pow_right` * `pow_le_pow_of_le_left` → `pow_le_pow_left` * `pow_lt_pow_of_lt_left` → `pow_lt_pow_left` * `strictMonoOn_pow` → `pow_left_strictMonoOn` * `pow_strictMono_right` → `pow_right_strictMono` * `pow_lt_pow` → `pow_lt_pow_right` * `pow_lt_pow_iff` → `pow_lt_pow_iff_right` * `pow_le_pow_iff` → `pow_le_pow_iff_right` * `self_lt_pow` → `lt_self_pow` * `strictAnti_pow` → `pow_right_strictAnti` * `pow_lt_pow_iff_of_lt_one` → `pow_lt_pow_iff_right_of_lt_one` * `pow_lt_pow_of_lt_one` → `pow_lt_pow_right_of_lt_one` * `lt_of_pow_lt_pow` → `lt_of_pow_lt_pow_left` * `le_of_pow_le_pow` → `le_of_pow_le_pow_left` ### `Algebra.GroupPower.CovariantClass` * `pow_lt_pow'` → `pow_lt_pow_right'` * `pow_strictMono_left` → `pow_right_strictMono'` * `nsmul_strictMono_right` → `nsmul_left_strictMono` * `StrictMono.pow_right'` → `StrictMono.pow_const` * `StrictMono.nsmul_left` → `StrictMono.const_nsmul` * `pow_strictMono_right'` → `pow_left_strictMono` * `nsmul_strictMono_left` → `nsmul_right_strictMono` * `Monotone.pow_right` → `Monotone.const_nsmul` ### `Data.Nat.Pow` * `Nat.pow_lt_pow_of_lt_left` → `Nat.pow_lt_pow_left` * `Nat.pow_le_iff_le_left` → `Nat.pow_le_pow_iff_left` * `Nat.pow_lt_iff_lt_left` → `Nat.pow_lt_pow_iff_left` ## Lemmas added * `pow_le_pow_iff_left` * `pow_lt_pow_iff_left` * `pow_right_injective` * `pow_right_inj` * `Nat.pow_le_pow_left` to have the correct name since `Nat.pow_le_pow_of_le_left` is in Std. * `Nat.pow_le_pow_right` to have the correct name since `Nat.pow_le_pow_of_le_right` is in Std. ## Lemmas removed * `self_le_pow` was a duplicate of `le_self_pow`. * `Nat.pow_lt_pow_of_lt_right` is defeq to `pow_lt_pow_right`. * `Nat.pow_right_strictMono` is defeq to `pow_right_strictMono`. * `Nat.pow_le_iff_le_right` is defeq to `pow_le_pow_iff_right`. * `Nat.pow_lt_iff_lt_right` is defeq to `pow_lt_pow_iff_right`. ## Other changes * A bunch of proofs have been golfed. * Some lemma assumptions have been turned from `0 < n` or `1 ≤ n` to `n ≠ 0`. * A few `Nat` lemmas have been `protected`. * One docstring has been fixed.
1 task
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
The names for lemmas about monotonicity of `(a ^ ·)` and `(· ^ n)` were a mess. This PR tidies up everything related by following the naming convention for `(a * ·)` and `(· * b)`. Namely, `(a ^ ·)` is `pow_right` and `(· ^ n)` is `pow_left` in lemma names. All lemma renames follow the corresponding multiplication lemma names closely. ## Renames ### `Algebra.GroupPower.Order` * `pow_mono` → `pow_right_mono` * `pow_le_pow` → `pow_le_pow_right` * `pow_le_pow_of_le_left` → `pow_le_pow_left` * `pow_lt_pow_of_lt_left` → `pow_lt_pow_left` * `strictMonoOn_pow` → `pow_left_strictMonoOn` * `pow_strictMono_right` → `pow_right_strictMono` * `pow_lt_pow` → `pow_lt_pow_right` * `pow_lt_pow_iff` → `pow_lt_pow_iff_right` * `pow_le_pow_iff` → `pow_le_pow_iff_right` * `self_lt_pow` → `lt_self_pow` * `strictAnti_pow` → `pow_right_strictAnti` * `pow_lt_pow_iff_of_lt_one` → `pow_lt_pow_iff_right_of_lt_one` * `pow_lt_pow_of_lt_one` → `pow_lt_pow_right_of_lt_one` * `lt_of_pow_lt_pow` → `lt_of_pow_lt_pow_left` * `le_of_pow_le_pow` → `le_of_pow_le_pow_left` * `pow_lt_pow₀` → `pow_lt_pow_right₀` ### `Algebra.GroupPower.CovariantClass` * `pow_le_pow_of_le_left'` → `pow_le_pow_left'` * `nsmul_le_nsmul_of_le_right` → `nsmul_le_nsmul_right` * `pow_lt_pow'` → `pow_lt_pow_right'` * `nsmul_lt_nsmul` → `nsmul_lt_nsmul_left` * `pow_strictMono_left` → `pow_right_strictMono'` * `nsmul_strictMono_right` → `nsmul_left_strictMono` * `StrictMono.pow_right'` → `StrictMono.pow_const` * `StrictMono.nsmul_left` → `StrictMono.const_nsmul` * `pow_strictMono_right'` → `pow_left_strictMono` * `nsmul_strictMono_left` → `nsmul_right_strictMono` * `Monotone.pow_right` → `Monotone.pow_const` * `Monotone.nsmul_left` → `Monotone.const_nsmul` * `lt_of_pow_lt_pow'` → `lt_of_pow_lt_pow_left'` * `lt_of_nsmul_lt_nsmul` → `lt_of_nsmul_lt_nsmul_right` * `pow_le_pow'` → `pow_le_pow_right'` * `nsmul_le_nsmul` → `nsmul_le_nsmul_left` * `pow_le_pow_of_le_one'` → `pow_le_pow_right_of_le_one'` * `nsmul_le_nsmul_of_nonpos` → `nsmul_le_nsmul_left_of_nonpos` * `le_of_pow_le_pow'` → `le_of_pow_le_pow_left'` * `le_of_nsmul_le_nsmul'` → `le_of_nsmul_le_nsmul_right'` * `pow_le_pow_iff'` → `pow_le_pow_iff_right'` * `nsmul_le_nsmul_iff` → `nsmul_le_nsmul_iff_left` * `pow_lt_pow_iff'` → `pow_lt_pow_iff_right'` * `nsmul_lt_nsmul_iff` → `nsmul_lt_nsmul_iff_left` ### `Data.Nat.Pow` * `Nat.pow_lt_pow_of_lt_left` → `Nat.pow_lt_pow_left` * `Nat.pow_le_iff_le_left` → `Nat.pow_le_pow_iff_left` * `Nat.pow_lt_iff_lt_left` → `Nat.pow_lt_pow_iff_left` ## Lemmas added * `pow_le_pow_iff_left` * `pow_lt_pow_iff_left` * `pow_right_injective` * `pow_right_inj` * `Nat.pow_le_pow_left` to have the correct name since `Nat.pow_le_pow_of_le_left` is in Std. * `Nat.pow_le_pow_right` to have the correct name since `Nat.pow_le_pow_of_le_right` is in Std. ## Lemmas removed * `self_le_pow` was a duplicate of `le_self_pow`. * `Nat.pow_lt_pow_of_lt_right` is defeq to `pow_lt_pow_right`. * `Nat.pow_right_strictMono` is defeq to `pow_right_strictMono`. * `Nat.pow_le_iff_le_right` is defeq to `pow_le_pow_iff_right`. * `Nat.pow_lt_iff_lt_right` is defeq to `pow_lt_pow_iff_right`. ## Other changes * A bunch of proofs have been golfed. * Some lemma assumptions have been turned from `0 < n` or `1 ≤ n` to `n ≠ 0`. * A few `Nat` lemmas have been `protected`. * One docstring has been fixed.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
The names for lemmas about monotonicity of `(a ^ ·)` and `(· ^ n)` were a mess. This PR tidies up everything related by following the naming convention for `(a * ·)` and `(· * b)`. Namely, `(a ^ ·)` is `pow_right` and `(· ^ n)` is `pow_left` in lemma names. All lemma renames follow the corresponding multiplication lemma names closely. ## Renames ### `Algebra.GroupPower.Order` * `pow_mono` → `pow_right_mono` * `pow_le_pow` → `pow_le_pow_right` * `pow_le_pow_of_le_left` → `pow_le_pow_left` * `pow_lt_pow_of_lt_left` → `pow_lt_pow_left` * `strictMonoOn_pow` → `pow_left_strictMonoOn` * `pow_strictMono_right` → `pow_right_strictMono` * `pow_lt_pow` → `pow_lt_pow_right` * `pow_lt_pow_iff` → `pow_lt_pow_iff_right` * `pow_le_pow_iff` → `pow_le_pow_iff_right` * `self_lt_pow` → `lt_self_pow` * `strictAnti_pow` → `pow_right_strictAnti` * `pow_lt_pow_iff_of_lt_one` → `pow_lt_pow_iff_right_of_lt_one` * `pow_lt_pow_of_lt_one` → `pow_lt_pow_right_of_lt_one` * `lt_of_pow_lt_pow` → `lt_of_pow_lt_pow_left` * `le_of_pow_le_pow` → `le_of_pow_le_pow_left` * `pow_lt_pow₀` → `pow_lt_pow_right₀` ### `Algebra.GroupPower.CovariantClass` * `pow_le_pow_of_le_left'` → `pow_le_pow_left'` * `nsmul_le_nsmul_of_le_right` → `nsmul_le_nsmul_right` * `pow_lt_pow'` → `pow_lt_pow_right'` * `nsmul_lt_nsmul` → `nsmul_lt_nsmul_left` * `pow_strictMono_left` → `pow_right_strictMono'` * `nsmul_strictMono_right` → `nsmul_left_strictMono` * `StrictMono.pow_right'` → `StrictMono.pow_const` * `StrictMono.nsmul_left` → `StrictMono.const_nsmul` * `pow_strictMono_right'` → `pow_left_strictMono` * `nsmul_strictMono_left` → `nsmul_right_strictMono` * `Monotone.pow_right` → `Monotone.pow_const` * `Monotone.nsmul_left` → `Monotone.const_nsmul` * `lt_of_pow_lt_pow'` → `lt_of_pow_lt_pow_left'` * `lt_of_nsmul_lt_nsmul` → `lt_of_nsmul_lt_nsmul_right` * `pow_le_pow'` → `pow_le_pow_right'` * `nsmul_le_nsmul` → `nsmul_le_nsmul_left` * `pow_le_pow_of_le_one'` → `pow_le_pow_right_of_le_one'` * `nsmul_le_nsmul_of_nonpos` → `nsmul_le_nsmul_left_of_nonpos` * `le_of_pow_le_pow'` → `le_of_pow_le_pow_left'` * `le_of_nsmul_le_nsmul'` → `le_of_nsmul_le_nsmul_right'` * `pow_le_pow_iff'` → `pow_le_pow_iff_right'` * `nsmul_le_nsmul_iff` → `nsmul_le_nsmul_iff_left` * `pow_lt_pow_iff'` → `pow_lt_pow_iff_right'` * `nsmul_lt_nsmul_iff` → `nsmul_lt_nsmul_iff_left` ### `Data.Nat.Pow` * `Nat.pow_lt_pow_of_lt_left` → `Nat.pow_lt_pow_left` * `Nat.pow_le_iff_le_left` → `Nat.pow_le_pow_iff_left` * `Nat.pow_lt_iff_lt_left` → `Nat.pow_lt_pow_iff_left` ## Lemmas added * `pow_le_pow_iff_left` * `pow_lt_pow_iff_left` * `pow_right_injective` * `pow_right_inj` * `Nat.pow_le_pow_left` to have the correct name since `Nat.pow_le_pow_of_le_left` is in Std. * `Nat.pow_le_pow_right` to have the correct name since `Nat.pow_le_pow_of_le_right` is in Std. ## Lemmas removed * `self_le_pow` was a duplicate of `le_self_pow`. * `Nat.pow_lt_pow_of_lt_right` is defeq to `pow_lt_pow_right`. * `Nat.pow_right_strictMono` is defeq to `pow_right_strictMono`. * `Nat.pow_le_iff_le_right` is defeq to `pow_le_pow_iff_right`. * `Nat.pow_lt_iff_lt_right` is defeq to `pow_lt_pow_iff_right`. ## Other changes * A bunch of proofs have been golfed. * Some lemma assumptions have been turned from `0 < n` or `1 ≤ n` to `n ≠ 0`. * A few `Nat` lemmas have been `protected`. * One docstring has been fixed.
YaelDillies
added a commit
that referenced
this pull request
Dec 23, 2023
Add deprecated aliases for all the lemmas removed in #9095
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2023
Add deprecated aliases for all the lemmas removed in #9095 and fix a few renames that were botched.
YaelDillies
added a commit
that referenced
this pull request
Nov 13, 2024
These new names match the ones introduced in the analogous PR #9095
YaelDillies
added a commit
that referenced
this pull request
Nov 13, 2024
These new names match the ones introduced in the analogous PR #9095
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
These new names match the ones introduced in the analogous PR #9095
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
These new names match the ones introduced in the analogous PR #9095
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
These new names match the ones introduced in the analogous PR #9095
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
These new names match the ones introduced in the analogous PR #9095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names for lemmas about monotonicity of
(a ^ ·)and(· ^ n)were a mess. This PR tidies up everything related by following the naming convention for(a * ·)and(· * b). Namely,(a ^ ·)ispow_rightand(· ^ n)ispow_leftin lemma names. All lemma renames follow the corresponding multiplication lemma names closely.Renames
Algebra.GroupPower.Orderpow_mono→pow_right_monopow_le_pow→pow_le_pow_rightpow_le_pow_of_le_left→pow_le_pow_leftpow_lt_pow_of_lt_left→pow_lt_pow_leftstrictMonoOn_pow→pow_left_strictMonoOnpow_strictMono_right→pow_right_strictMonopow_lt_pow→pow_lt_pow_rightpow_lt_pow_iff→pow_lt_pow_iff_rightpow_le_pow_iff→pow_le_pow_iff_rightself_lt_pow→lt_self_powstrictAnti_pow→pow_right_strictAntipow_lt_pow_iff_of_lt_one→pow_lt_pow_iff_right_of_lt_onepow_lt_pow_of_lt_one→pow_lt_pow_right_of_lt_onelt_of_pow_lt_pow→lt_of_pow_lt_pow_leftle_of_pow_le_pow→le_of_pow_le_pow_leftpow_lt_pow₀→pow_lt_pow_right₀Algebra.GroupPower.CovariantClasspow_le_pow_of_le_left'→pow_le_pow_left'nsmul_le_nsmul_of_le_right→nsmul_le_nsmul_rightpow_lt_pow'→pow_lt_pow_right'nsmul_lt_nsmul→nsmul_lt_nsmul_leftpow_strictMono_left→pow_right_strictMono'nsmul_strictMono_right→nsmul_left_strictMonoStrictMono.pow_right'→StrictMono.pow_constStrictMono.nsmul_left→StrictMono.const_nsmulpow_strictMono_right'→pow_left_strictMononsmul_strictMono_left→nsmul_right_strictMonoMonotone.pow_right→Monotone.pow_constMonotone.nsmul_left→Monotone.const_nsmullt_of_pow_lt_pow'→lt_of_pow_lt_pow_left'lt_of_nsmul_lt_nsmul→lt_of_nsmul_lt_nsmul_rightpow_le_pow'→pow_le_pow_right'nsmul_le_nsmul→nsmul_le_nsmul_leftpow_le_pow_of_le_one'→pow_le_pow_right_of_le_one'nsmul_le_nsmul_of_nonpos→nsmul_le_nsmul_left_of_nonposle_of_pow_le_pow'→le_of_pow_le_pow_left'le_of_nsmul_le_nsmul'→le_of_nsmul_le_nsmul_right'pow_le_pow_iff'→pow_le_pow_iff_right'nsmul_le_nsmul_iff→nsmul_le_nsmul_iff_leftpow_lt_pow_iff'→pow_lt_pow_iff_right'nsmul_lt_nsmul_iff→nsmul_lt_nsmul_iff_leftData.Nat.PowNat.pow_lt_pow_of_lt_left→Nat.pow_lt_pow_leftNat.pow_le_iff_le_left→Nat.pow_le_pow_iff_leftNat.pow_lt_iff_lt_left→Nat.pow_lt_pow_iff_leftLemmas added
pow_le_pow_iff_leftpow_lt_pow_iff_leftpow_right_injectivepow_right_injNat.pow_le_pow_leftto have the correct name sinceNat.pow_le_pow_of_le_leftis in Std.Nat.pow_le_pow_rightto have the correct name sinceNat.pow_le_pow_of_le_rightis in Std.Lemmas removed
self_le_powwas a duplicate ofle_self_pow.Nat.pow_lt_pow_of_lt_rightis defeq topow_lt_pow_right.Nat.pow_right_strictMonois defeq topow_right_strictMono.Nat.pow_le_iff_le_rightis defeq topow_le_pow_iff_right.Nat.pow_lt_iff_lt_rightis defeq topow_lt_pow_iff_right.Other changes
0 < nor1 ≤ nton ≠ 0.Natlemmas have beenprotected.