chore(SetTheory/Cardinal/Basic): make types more explicit#8291
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
chore(SetTheory/Cardinal/Basic): make types more explicit#8291eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser wants to merge 3 commits intomasterfrom
Conversation
When reading this file, it is difficult to tell whether statements are about ordinal or natural powers; especially given that when leanprover/lean4#2220 is fixed the meanings may change. This adds type annotations to remove the ambiguity.
3 tasks
Contributor
|
Please make sure this is synchronized with the efforts in #8284 and won't make the Lean version bump any more difficult. |
Member
Author
|
Feel free to ping me on #8284 once this is merged, and I'll sort out the conflicts. |
Member
Author
|
Looking more closely at the conflicts in #8284; merging this PR will make them easier to resolve. |
eric-wieser
added a commit
that referenced
this pull request
Nov 9, 2023
This folds in the changes from #8291
eric-wieser
added a commit
that referenced
this pull request
Nov 9, 2023
This folds in the changes from #8291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading this file, it is difficult to tell whether statements are about ordinal or natural powers; especially given that when leanprover/lean4#2220 is fixed the meanings may change.
This commit adds type annotations to remove the ambiguity, but does not change the type of any statements.