[Merged by Bors] - style(SetTheory): remove useless parentheses#8279
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - style(SetTheory): remove useless parentheses#8279eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser wants to merge 1 commit intomasterfrom
Conversation
These were caused by a bad notation precedence in mathlib3, where the local version of `^` was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).
3 tasks
Contributor
|
This is a nice fix, thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
These were caused by a bad notation precedence in mathlib3, where the local version of `^` was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Contributor
|
(Unfortunately this will cause merge conflicts with the fixes for #2220... Oh well) |
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
These were caused by a bad notation precedence in mathlib3, where the local version of `^` was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were caused by a bad notation precedence in mathlib3, where the local version of
^was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).Cleaning up this file now makes it easier to deal with fallout from attempts to fix leanprover/lean4#2220