Skip to content

[Merged by Bors] - feat: sigma-compact sets#7576

Closed
grunweg wants to merge 34 commits intomasterfrom
MR-sigma-compact
Closed

[Merged by Bors] - feat: sigma-compact sets#7576
grunweg wants to merge 34 commits intomasterfrom
MR-sigma-compact

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Oct 8, 2023

Define sigma-compact subsets of a topological space and show their basic properties.

  • compact sets are sigma-compact
  • countable unions of (sigma-)compact sets are sigma-compact
  • closed subsets of sigma-compact sets are sigma-compact.

Relate them to sigma-compact space: a set is sigma-compact iff it is a sigma-compact space (w.r.t. the subspace topology).

In a later PR, we'll show that sigma-compact measure zero sets are nowhere dense.


Similar to compact sets and spaces, we define sigma-compact subsets first, and relate sigma-compact spaces to them later.

@grunweg grunweg added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Oct 8, 2023
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 8, 2023
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 9, 2023
@ghost
Copy link
Copy Markdown

ghost commented Oct 9, 2023

This PR/issue depends on:

@grunweg grunweg force-pushed the MR-sigma-compact branch 2 times, most recently from 079f039 to 2f7867a Compare October 9, 2023 08:07
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 9, 2023

@eric-wieser CI passes, so making the lemma you mentioned simp works. I presume Homeomorph.isCompact_image should also be a simp lemma then, and have PRed this as #7594.
I've also added the analogous version for preimages.

(I've also made the renames locally, but not checked all of mathlib yet; happy to drop those changes if need be. Update: CI passes, so presumably all is fine.)

Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks very good already!

@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Oct 10, 2023
loefflerd and others added 2 commits October 11, 2023 23:12
Co-authored-by: Oliver Nash <github@olivernash.org>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 11, 2023

(Cancelling the build as this will need a rebase due to #7628 anyway.)

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 11, 2023
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 12, 2023
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait! I think this is mostly good now, at most one more round.

@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Oct 15, 2023
@grunweg grunweg added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Oct 16, 2023
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 16, 2023

I have addressed all the comments, and also included some last touch-ups of related doc comments (in the last commit).

Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Oct 16, 2023

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Oct 16, 2023
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 16, 2023

Thank you for the patient review.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 16, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 16, 2023
Define sigma-compact subsets of a topological space and show their basic properties.

* compact sets are sigma-compact
* countable unions of (sigma-)compact sets are sigma-compact
* closed subsets of sigma-compact sets are sigma-compact.

Relate them to sigma-compact space: a set is sigma-compact iff it is a sigma-compact space (w.r.t. the subspace topology).

In a later PR, we'll show that sigma-compact measure zero sets are nowhere dense.

- [x] depends on: #7528


Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Co-authored-by: grunweg <grunweg@posteo.de>
@bors
Copy link
Copy Markdown

bors bot commented Oct 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: sigma-compact sets [Merged by Bors] - feat: sigma-compact sets Oct 16, 2023
@bors bors bot closed this Oct 16, 2023
@bors bors bot deleted the MR-sigma-compact branch October 16, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants