[Merged by Bors] - perf(Polynomial): fix CommSemiring instance missed in #7434#7518
Closed
ChrisHughes24 wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - perf(Polynomial): fix CommSemiring instance missed in #7434#7518ChrisHughes24 wants to merge 2 commits intomasterfrom
ChrisHughes24 wants to merge 2 commits intomasterfrom
Conversation
1 task
Contributor
|
We should probably be stripping out the bors merge |
Member
Author
I don't think so, at least not for polynomial. They're only ever used to fill in propositional fields. |
Contributor
|
Aesthetics and ease of reading. |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The easy tag is because it's easy for @mattrobball who knows what's going on.