[Merged by Bors] - perf: improve some instances in Polynomial#7434
Closed
ChrisHughes24 wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - perf: improve some instances in Polynomial#7434ChrisHughes24 wants to merge 3 commits intomasterfrom
ChrisHughes24 wants to merge 3 commits intomasterfrom
Conversation
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit c5bca0a. Benchmark Metric Change
=================================================================================
+ ~Mathlib.AlgebraicGeometry.EllipticCurve.Point instructions -40.6%
+ ~Mathlib.AlgebraicGeometry.EllipticCurve.Weierstrass instructions -19.5%
- ~Mathlib.Data.Polynomial.Basic instructions 20.3%
+ ~Mathlib.Data.Polynomial.Div instructions -8.7%
+ ~Mathlib.Data.Polynomial.Lifts instructions -7.6%
+ ~Mathlib.FieldTheory.Finite.GaloisField instructions -15.9%
+ ~Mathlib.FieldTheory.IsAlgClosed.Spectrum instructions -8.2%
+ ~Mathlib.FieldTheory.IsSepClosed instructions -7.4%
+ ~Mathlib.FieldTheory.Normal instructions -6.3%
+ ~Mathlib.FieldTheory.Perfect instructions -5.8%
+ ~Mathlib.FieldTheory.PrimitiveElement instructions -7.5%
+ ~Mathlib.FieldTheory.SplittingField.Construction instructions -11.6%
+ ~Mathlib.FieldTheory.SplittingField.IsSplittingField instructions -8.7%
+ ~Mathlib.LinearAlgebra.AnnihilatingPolynomial instructions -26.1%
+ ~Mathlib.LinearAlgebra.FreeModule.Norm instructions -61.0%
+ ~Mathlib.LinearAlgebra.Lagrange instructions -5.8%
+ ~Mathlib.LinearAlgebra.Matrix.Charpoly.Basic instructions -9.7%
+ ~Mathlib.LinearAlgebra.Matrix.Charpoly.Coeff instructions -7.6%
+ ~Mathlib.LinearAlgebra.Matrix.Charpoly.FiniteField instructions -24.9%
+ ~Mathlib.NumberTheory.BernoulliPolynomials instructions -6.7%
+ ~Mathlib.NumberTheory.ClassNumber.AdmissibleCardPowDegree instructions -6.3%
+ ~Mathlib.NumberTheory.ClassNumber.FunctionField instructions -20.5%
+ ~Mathlib.NumberTheory.KummerDedekind instructions -7.0%
+ ~Mathlib.RingTheory.AdjoinRoot instructions -49.9%
+ ~Mathlib.RingTheory.AlgebraicIndependent instructions -5.1%
+ ~Mathlib.RingTheory.Jacobson instructions -33.6%
+ ~Mathlib.RingTheory.JacobsonIdeal instructions -8.9%
+ ~Mathlib.RingTheory.Polynomial.Chebyshev instructions -5.3%
+ ~Mathlib.RingTheory.Polynomial.GaussLemma instructions -6.7%
+ ~Mathlib.RingTheory.Polynomial.Nilpotent instructions -8.9%
+ ~Mathlib.RingTheory.Polynomial.Quotient instructions -28.4%
+ ~Mathlib.RingTheory.RootsOfUnity.Minpoly instructions -7.9% |
Member
|
Note also that build instructions (a measurement of total build time) goes down 0.92%. 🎉 |
mattrobball
reviewed
Oct 2, 2023
| @@ -291,18 +291,27 @@ instance natCast : NatCast R[X] := | |||
| #align polynomial.has_nat_cast Polynomial.natCast | |||
|
|
|||
| instance semiring : Semiring R[X] := | |||
Contributor
There was a problem hiding this comment.
Would building up through the hierarchy to Semiring R[X] yield even better performance? Or would it be middling?
Contributor
There was a problem hiding this comment.
Same with other ones below.
Member
Author
There was a problem hiding this comment.
Possibly. I don't see why it would but it is certainly possible that it could because I don't fully understand this stuff
Member
Author
There was a problem hiding this comment.
How about merging this and I experiment with further improvements in another PR?
Contributor
|
bors d+ |
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
ChrisHughes24
added a commit
that referenced
this pull request
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.