Conversation
mcdoll
approved these changes
Nov 20, 2022
Member
mcdoll
left a comment
There was a problem hiding this comment.
LGTM
I like autoimplicits here, because α and β are almost always just arbitrary types.
Mathlib/Order/GameAdd.lean
Outdated
| -/ | ||
|
|
||
|
|
||
| variable {α β : Type _} (rα : α → α → Prop) (rβ : β → β → Prop) |
Member
There was a problem hiding this comment.
Suggested change
| variable {α β : Type _} (rα : α → α → Prop) (rβ : β → β → Prop) | |
| variable (rα : α → α → Prop) (rβ : β → β → Prop) |
see https://github.com/leanprover-community/mathlib4/wiki#auto-implicits
Mathlib/Order/GameAdd.lean
Outdated
| /-- If `a` is accessible under `rα` and `b` is accessible under `rβ`, then `(a, b)` is | ||
| accessible under `Prod.GameAdd rα rβ`. Notice that `Prod.lexAccessible` requires the | ||
| stronger condition `∀ b, Acc rβ b`. -/ | ||
| theorem Acc.prod_gameAdd {a b} (ha : Acc rα a) (hb : Acc rβ b) : |
Member
There was a problem hiding this comment.
Suggested change
| theorem Acc.prod_gameAdd {a b} (ha : Acc rα a) (hb : Acc rβ b) : | |
| theorem Acc.prod_gameAdd (ha : Acc rα a) (hb : Acc rβ b) : |
I don't understand why these variables are mentioned
Contributor
|
After making the changes, Moritz suggested, bors d+ |
|
✌️ dwarn can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 20, 2022
mathlib SHA: fd47bdf09e90f553519c712378e651975fe8c829
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 21, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * leanprover-community/mathlib4#563 * leanprover-community/mathlib4#608 * leanprover-community/mathlib4#627 * leanprover-community/mathlib4#638 * leanprover-community/mathlib4#641 * leanprover-community/mathlib4#645 * leanprover-community/mathlib4#650
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 21, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * leanprover-community/mathlib4#563 * leanprover-community/mathlib4#608 * leanprover-community/mathlib4#627 * leanprover-community/mathlib4#638 * leanprover-community/mathlib4#641 * leanprover-community/mathlib4#645 * leanprover-community/mathlib4#650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib SHA: fd47bdf09e90f553519c712378e651975fe8c829