[Merged by Bors] - feat: port Algebra.Order.Hom.Basic#627
Closed
riccardobrasca wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - feat: port Algebra.Order.Hom.Basic#627riccardobrasca wants to merge 9 commits intomasterfrom
riccardobrasca wants to merge 9 commits intomasterfrom
Conversation
kim-em
reviewed
Nov 20, 2022
| variable {ι F α β γ δ : Type _} | ||
|
|
||
| /-- `NonNegHomClass F α β` states that `F` is a type of nonnegative morphisms. -/ | ||
| class NonNegHomClass (F : Type _) (α β : outParam (Type _)) [outParam (Zero β)] [outParam (LE β)] |
Contributor
There was a problem hiding this comment.
Lean4 nightly 2022-11-20 will remove the need for the outParams on typeclasses. Could you leave a porting note to that effect?
Member
Author
There was a problem hiding this comment.
I will fix this when possible, thanks!
kim-em
reviewed
Nov 20, 2022
Contributor
|
Besides the comment issues: bors d+ Please make sure to update the port-status wiki page when you merge. |
|
✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 20, 2022
mathlib3 sha: 17ef379e997badd73e5eabb4d38f11919ab3c4b3
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 21, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * leanprover-community/mathlib4#563 * leanprover-community/mathlib4#608 * leanprover-community/mathlib4#627 * leanprover-community/mathlib4#638 * leanprover-community/mathlib4#641 * leanprover-community/mathlib4#645 * leanprover-community/mathlib4#650
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 21, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * leanprover-community/mathlib4#563 * leanprover-community/mathlib4#608 * leanprover-community/mathlib4#627 * leanprover-community/mathlib4#638 * leanprover-community/mathlib4#641 * leanprover-community/mathlib4#645 * leanprover-community/mathlib4#650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3 sha: 17ef379e997badd73e5eabb4d38f11919ab3c4b3