[Merged by Bors] - feat: IsROrC.toStarOrderedRing as a scoped instance#6391
Closed
eric-wieser wants to merge 28 commits intomasterfrom
Closed
[Merged by Bors] - feat: IsROrC.toStarOrderedRing as a scoped instance#6391eric-wieser wants to merge 28 commits intomasterfrom
eric-wieser wants to merge 28 commits intomasterfrom
Conversation
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…ty/mathlib4 into IsROrCStarOrderedRing
eric-wieser
commented
Aug 5, 2023
Mathlib/Analysis/NormedSpace/Star/ContinuousFunctionalCalculus.lean
Outdated
Show resolved
Hide resolved
8b6cd49 to
d044d2e
Compare
j-loreaux
reviewed
Aug 8, 2023
Contributor
j-loreaux
left a comment
There was a problem hiding this comment.
I'm content with this while we decide whether we want a globally available partial order on ℂ.
However, please add a docstring to the StarOrderedRing ℝ instance in Mathlib.Data.Real.Sqrt saying that it exists separate from the IsROrC instance because that one is blocked behind the ComplexOrder scope and we want it to be availble globally.
Mathlib/Data/IsROrC/Basic.lean
Outdated
| namespace IsROrC | ||
|
|
||
| open scoped ComplexOrder in | ||
| /-- Note this is only an instance with `open scoped ComplexOrder`. -/ |
Contributor
There was a problem hiding this comment.
I think it would be nice to keep this portion of the docstring from the ℂ instance:
Suggested change
| /-- Note this is only an instance with `open scoped ComplexOrder`. -/ | |
| /-- With `z ≤ w` iff `w - z` is real and nonnegative, `IsROrC K` is a star ordered ring. | |
| (That is, a star ring in which the nonnegative elements are those of the form `star z * z`.) | |
| Note this is only an instance with `open scoped ComplexOrder`. -/ |
Contributor
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
This PR/issue depends on:
|
eric-wieser
commented
Aug 9, 2023
| rw [lt_iff_re_im, map_zero] at hz hw ⊢ | ||
| simp [mul_re, mul_im, ← hz.2, ← hw.2, mul_pos hz.1 hw.1] | ||
| mul_comm := by intros; apply ext <;> ring_nf | ||
|
|
Member
Author
There was a problem hiding this comment.
Oops, I missed the instance line here
Contributor
|
This still LGTM after the changes. Feel free to merge. |
Member
Author
|
bors merge I'm pretty confident the instance line won't make any difference to CI |
bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
With `open scoped ComplexOrder`, we current have `StarOrderedRing Complex` (as well as some other order instances). With this PR, that scope puts the same order on `K` where `IsROrC K`. There is an ongoing discussion about whether opening the scope should be required, but there is no need to address that concern simultaneously with improving behavior when the scope is *already* open. There also seems to be fewer downstream instance resolution issues to resolve by leaving it in the scope. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
With `open scoped ComplexOrder`, we current have `StarOrderedRing Complex` (as well as some other order instances). With this PR, that scope puts the same order on `K` where `IsROrC K`. There is an ongoing discussion about whether opening the scope should be required, but there is no need to address that concern simultaneously with improving behavior when the scope is *already* open. There also seems to be fewer downstream instance resolution issues to resolve by leaving it in the scope. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
open scoped ComplexOrder, we current haveStarOrderedRing Complex(as well as some other order instances).With this PR, that scope puts the same order on
KwhereIsROrC K.There is an ongoing discussion about whether opening the scope should be required, but there is no need to address that concern simultaneously with improving behavior when the scope is already open. There also seems to be fewer downstream instance resolution issues to resolve by leaving it in the scope.
This is a more conservative version of #6210, which does not simultaneously remove the
ComplexOrderscope.