[Merged by Bors] - chore(Data/Complex): move order to a separate file#6457
Closed
eric-wieser wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data/Complex): move order to a separate file#6457eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser wants to merge 4 commits intomasterfrom
Conversation
eric-wieser
commented
Aug 8, 2023
Comment on lines
+2
to
+4
| Copyright (c) 2021 Scott Morrison. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Scott Morrison |
Member
Author
There was a problem hiding this comment.
1 task
j-loreaux
reviewed
Aug 9, 2023
Contributor
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Given how confusing this order could be to newcomers, it's probably not reasonable to call it `Basic`. At any rate, `Data/Complex/Basic` is very long, and this is an easy split.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
Given how confusing this order could be to newcomers, it's probably not reasonable to call it `Basic`. At any rate, `Data/Complex/Basic` is very long, and this is an easy split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given how confusing this order could be to newcomers, it's probably not reasonable to call it
Basic.At any rate,
Data/Complex/Basicis very long, and this is an easy split.