[Merged by Bors] - feat: generalize scalars in Algebra.lsmul#6209
Closed
eric-wieser wants to merge 14 commits intomasterfrom
Closed
[Merged by Bors] - feat: generalize scalars in Algebra.lsmul#6209eric-wieser wants to merge 14 commits intomasterfrom
eric-wieser wants to merge 14 commits intomasterfrom
Conversation
…ra instance This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
Member
Author
|
(note the CI failure will be resolved once the dependent PR is merged) |
|
This PR/issue depends on: |
3 tasks
Contributor
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
This generalizes from `Algebra.lsmul R M : A →ₐ[R] Module.End R M` to `Algebra.lsmul R S M : A →ₐ[R] Module.End S M`. This generalization was previously not possible because `Module.End S M` was not an `R`-algebra. Notably this now allows things like `Algebra.lsmul R A A : Aᵐᵒᵖ →ₐ[R] Module.End A A` (right multiplication). This doesn't bother attempting to generalize uses in downstream files, as most of them probably do not need the generality. Instead, we just replace `Algebra.lsmul R` with `Algebra.lsmul R R`.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 3, 2023
This generalizes from `Algebra.lsmul R M : A →ₐ[R] Module.End R M` to `Algebra.lsmul R S M : A →ₐ[R] Module.End S M`. This generalization was previously not possible because `Module.End S M` was not an `R`-algebra. Notably this now allows things like `Algebra.lsmul R A A : Aᵐᵒᵖ →ₐ[R] Module.End A A` (right multiplication). This doesn't bother attempting to generalize uses in downstream files, as most of them probably do not need the generality. Instead, we just replace `Algebra.lsmul R` with `Algebra.lsmul R R`.
kim-em
pushed a commit
that referenced
this pull request
Aug 3, 2023
This generalizes from `Algebra.lsmul R M : A →ₐ[R] Module.End R M` to `Algebra.lsmul R S M : A →ₐ[R] Module.End S M`. This generalization was previously not possible because `Module.End S M` was not an `R`-algebra. Notably this now allows things like `Algebra.lsmul R A A : Aᵐᵒᵖ →ₐ[R] Module.End A A` (right multiplication). This doesn't bother attempting to generalize uses in downstream files, as most of them probably do not need the generality. Instead, we just replace `Algebra.lsmul R` with `Algebra.lsmul R R`.
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
This generalizes from `Algebra.lsmul R M : A →ₐ[R] Module.End R M` to `Algebra.lsmul R S M : A →ₐ[R] Module.End S M`. This generalization was previously not possible because `Module.End S M` was not an `R`-algebra. Notably this now allows things like `Algebra.lsmul R A A : Aᵐᵒᵖ →ₐ[R] Module.End A A` (right multiplication). This doesn't bother attempting to generalize uses in downstream files, as most of them probably do not need the generality. Instead, we just replace `Algebra.lsmul R` with `Algebra.lsmul R R`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generalizes from
Algebra.lsmul R M : A →ₐ[R] Module.End R MtoAlgebra.lsmul R S M : A →ₐ[R] Module.End S M.This generalization was previously not possible because
Module.End S Mwas not anR-algebra.Notably this now allows things like
Algebra.lsmul R A A : Aᵐᵒᵖ →ₐ[R] Module.End A A(right multiplication).This doesn't bother attempting to generalize uses in downstream files, as most of them probably do not need the generality.
Instead, we just replace
Algebra.lsmul RwithAlgebra.lsmul R R.