[Merged by Bors] - refactor(Algebra/Module/LinearMap): generalize the endomorphism algebra instance#6207
Closed
eric-wieser wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Algebra/Module/LinearMap): generalize the endomorphism algebra instance#6207eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser wants to merge 4 commits intomasterfrom
Conversation
…ra instance This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
1 task
Contributor
|
I will try to make some time to do reviewing in the next days! |
bors bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…ra instance (#6207) Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra. This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ra instance (#6207) Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra. This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ra instance (#6207) Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra. This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra.
This also moves some lemmas about
IsUnit (_ : Module.End R M)to an earlier file as they are nothing to do withAlgebra.