[Merged by Bors] - feat: Estimator typeclass and implementation for Levenshtein distance#6119
Closed
[Merged by Bors] - feat: Estimator typeclass and implementation for Levenshtein distance#6119
Conversation
…t_distance_estimator
…_distance_estimator_new
11 tasks
Comment on lines
+82
to
+84
| rw [e.distances_eq] at eq | ||
| simp only [List.getElem_eq_get] at eq | ||
| rw [split] at eq |
Member
There was a problem hiding this comment.
What's happening here? Can't you reduce this to a single simp only or at least a simp_rw?
Contributor
Author
There was a problem hiding this comment.
Unfortunately not: changing the first rw to a simp_rw causes the last rw to error with a "motive not type correct". simp doesn't make any progress when used in place of the last rw.
Ugly, hey? I'm inclined to say this is just unfixable DTT unpleasantness.
Comment on lines
+101
to
+103
| rw [e.distances_eq] at eq | ||
| simp only [List.getElem_eq_get] at eq | ||
| rw [split] at eq |
Member
There was a problem hiding this comment.
Same remark here. I really feels like the simp set isn't good enough.
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
…y/mathlib4 into edit_distance_bounds
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
…#6119) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Thomas Browning <tb65536@uw.edu> Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Oliver Nash <github@olivernash.org> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: Alex J Best <alex.j.best@gmail.com> Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com> Co-authored-by: michaellee94 <michael_lee1@brown.edu>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.