Skip to content

[Merged by Bors] - feat: Extending from Ici a#5829

Closed
YaelDillies wants to merge 5 commits intomasterfrom
proj_Ici
Closed

[Merged by Bors] - feat: Extending from Ici a#5829
YaelDillies wants to merge 5 commits intomasterfrom
proj_Ici

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jul 12, 2023

Given a linearly ordered type `α`, in this file we define

* `Set.projIci (a : α)` to be the map `α → [a, ∞[` sending `]-∞, a]` to `a`, and each point
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we normally use [a, ∞) not [a, ∞[?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh sure, but that's not what the mathlib docstring uses.

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@bors
Copy link
Copy Markdown

bors bot commented Jul 13, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em kim-em added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jul 13, 2023
@YaelDillies
Copy link
Copy Markdown
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 14, 2023
leanprover-community/mathlib3#18795




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jul 14, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Extending from Ici a [Merged by Bors] - feat: Extending from Ici a Jul 14, 2023
@bors bors bot closed this Jul 14, 2023
@bors bors bot deleted the proj_Ici branch July 14, 2023 16:34
kbuzzard pushed a commit that referenced this pull request Jul 15, 2023
leanprover-community/mathlib3#18795




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em pushed a commit that referenced this pull request Aug 14, 2023
leanprover-community/mathlib3#18795




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants