Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/set/intervals/proj_Icc): Extending from Ici a#18795

Closed
YaelDillies wants to merge 4 commits intomasterfrom
proj_Ici
Closed

[Merged by Bors] - feat(data/set/intervals/proj_Icc): Extending from Ici a#18795
YaelDillies wants to merge 4 commits intomasterfrom
proj_Ici

Conversation

@YaelDillies
Copy link
Copy Markdown
Collaborator

@YaelDillies YaelDillies commented Apr 12, 2023

Define the Ici and Iic versions of set.proj_Icc/set.Icc_extend. Slightly reorder the lemmas to allow better overall structure.

This is useful for extending convex functions by a junk value.


Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. labels Apr 12, 2023
variables [preorder β] {a b : α} (h : a ≤ b) {f : Icc a b → β}
variables [preorder β] {s t : set α} {a b : α} (h : a ≤ b) {f : Icc a b → β}

protected lemma monotone.Ici_extend {f : Ici a → β} (hf : monotone f) : monotone (Ici_extend f) :=
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these sorts of lemmas be tagged @[mono]?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can @[mono] deal with lemmas that have assumptions?

Copy link
Copy Markdown
Collaborator Author

@YaelDillies YaelDillies Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really unsure...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it in some example?

@urkud
Copy link
Copy Markdown
Member

urkud commented Jun 21, 2023

LGTM. Please add a comment about future applications of new definitions to the commit message. Thanks!
bors d+

@bors
Copy link
Copy Markdown

bors bot commented Jun 21, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud urkud added the blocked-by-out-of-sync-queue The #outofsync queue must have at most 20 items label Jun 21, 2023
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
@YaelDillies YaelDillies removed the blocked-by-out-of-sync-queue The #outofsync queue must have at most 20 items label Jul 11, 2023
@YaelDillies
Copy link
Copy Markdown
Collaborator Author

Unblocked now

bors merge

bors bot pushed a commit that referenced this pull request Jul 11, 2023
Define the `Ici` and `Iic` versions of `set.proj_Icc`/`set.Icc_extend`. Slightly reorder the lemmas to allow better overall structure.

This is useful for extending convex functions by a junk value.
@bors
Copy link
Copy Markdown

bors bot commented Jul 11, 2023

Build failed:

@YaelDillies
Copy link
Copy Markdown
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 11, 2023
Define the `Ici` and `Iic` versions of `set.proj_Icc`/`set.Icc_extend`. Slightly reorder the lemmas to allow better overall structure.

This is useful for extending convex functions by a junk value.
@bors
Copy link
Copy Markdown

bors bot commented Jul 11, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(data/set/intervals/proj_Icc): Extending from Ici a [Merged by Bors] - feat(data/set/intervals/proj_Icc): Extending from Ici a Jul 11, 2023
@bors bors bot closed this Jul 11, 2023
@bors bors bot deleted the proj_Ici branch July 11, 2023 17:46
YaelDillies added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 12, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 14, 2023
leanprover-community/mathlib3#18795




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kbuzzard pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 15, 2023
leanprover-community/mathlib3#18795




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 14, 2023
leanprover-community/mathlib3#18795




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-order Order hierarchy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants