[Merged by Bors] - refactor: move all register_simp_attrs to 1 file#5681
Closed
[Merged by Bors] - refactor: move all register_simp_attrs to 1 file#5681
register_simp_attrs to 1 file#5681Conversation
Member
|
Thanks 🎉 If CI passes, please remove the label bors d+ |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
There are slight differences between `mathlib3` and `mathlib4` (different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes. mathlib3 PR: leanprover-community/mathlib3#19223
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
register_simp_attrs to 1 fileregister_simp_attrs to 1 file
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
There are slight differences between `mathlib3` and `mathlib4` (different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes. mathlib3 PR: leanprover-community/mathlib3#19223
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
There are slight differences between `mathlib3` and `mathlib4` (different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes. mathlib3 PR: leanprover-community/mathlib3#19223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are slight differences between
mathlib3andmathlib4(different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes.mathlib3 PR: leanprover-community/mathlib3#19223