Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - refactor(*): move all mk_simp_attribute commands to 1 file#19223

Closed
urkud wants to merge 2 commits intomasterfrom
YK-simp-attrs
Closed

[Merged by Bors] - refactor(*): move all mk_simp_attribute commands to 1 file#19223
urkud wants to merge 2 commits intomasterfrom
YK-simp-attrs

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jun 30, 2023


Open in Gitpod

@urkud urkud requested review from a team as code owners June 30, 2023 03:44
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Jun 30, 2023
@urkud urkud added awaiting-review The author would like community review of the PR mathport For compatibility with Lean 4 changes, to simplify porting labels Jun 30, 2023
@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 30, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jun 30, 2023

Build failed:

@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jun 30, 2023

Build was killed, let's try again.
bors merge

@bors
Copy link
Copy Markdown

bors bot commented Jun 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor(*): move all mk_simp_attribute commands to 1 file [Merged by Bors] - refactor(*): move all mk_simp_attribute commands to 1 file Jun 30, 2023
@bors bors bot closed this Jun 30, 2023
@bors bors bot deleted the YK-simp-attrs branch June 30, 2023 15:09
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 3, 2023
There are slight differences between `mathlib3` and `mathlib4` (different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes.

mathlib3 PR: leanprover-community/mathlib3#19223
kbuzzard pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 6, 2023
There are slight differences between `mathlib3` and `mathlib4` (different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes.

mathlib3 PR: leanprover-community/mathlib3#19223
kim-em pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 14, 2023
There are slight differences between `mathlib3` and `mathlib4` (different set of attributes, different lemmas are in core/std), so I redid the same refactor instead of forward-porting changes.

mathlib3 PR: leanprover-community/mathlib3#19223
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mathport For compatibility with Lean 4 changes, to simplify porting modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants