Conversation
12 tasks
kim-em
reviewed
Nov 1, 2022
Co-authored-by: Scott Morrison <scott@tqft.net>
Contributor
|
What about goals like which should also count as "in the language of commutative rings"? Presumably it is easier to first |
Contributor
|
bors d+ |
|
✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
Another complete rewrite. This implements one `ring` to rule them all: it incorporates both `ring_exp` and `ring` behaviors, now under the name `ring`. (`ring_exp` had some small (1.4x) performance issues that prevented it from being used by default; I'm hoping that those issues are fixed now, and we can revisit later if it becomes an issue.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
ring_exp tactic, subtraction in ringring_exp tactic, subtraction in ring
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
TODO: * Before merge - [x] fix a bug in linarith in mathlib3 I just found ... - [x] depends on: #519 - [x] style lint - [x] docs - [X] move theory stubs to a separate PR, for easier tracking: #733 - [x] failing to parse the `LinarithConfig` option * Before or after merge? - [ ] Implement the `removeNe` preprocessor. - [ ] Add support for restricting to a single type. How to store a `Type` in `LinarithConfig`? * After merge - [ ] Teach `norm_num` to solve `example [LinearOrderedRing α] : (0 : α) < 37 := by norm_num`. - [ ] Port `zify_proof` (plumbing for `zify`), and add the `natToInt` preprocessor. Mostly done now, but see #741 before all the tests will work. - [ ] Port `cancel_denoms` tactic, and add the `cancelDenoms` preprocessor. - [ ] Add the `nlinarith` preprocessor and front-end syntax. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
TODO: * Before merge - [x] fix a bug in linarith in mathlib3 I just found ... - [x] depends on: #519 - [x] style lint - [x] docs - [X] move theory stubs to a separate PR, for easier tracking: #733 - [x] failing to parse the `LinarithConfig` option * Before or after merge? - [ ] Implement the `removeNe` preprocessor. - [ ] Add support for restricting to a single type. How to store a `Type` in `LinarithConfig`? * After merge - [ ] Teach `norm_num` to solve `example [LinearOrderedRing α] : (0 : α) < 37 := by norm_num`. - [ ] Port `zify_proof` (plumbing for `zify`), and add the `natToInt` preprocessor. Mostly done now, but see #741 before all the tests will work. - [ ] Port `cancel_denoms` tactic, and add the `cancelDenoms` preprocessor. - [ ] Add the `nlinarith` preprocessor and front-end syntax. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
TODO: * Before merge - [x] fix a bug in linarith in mathlib3 I just found ... - [x] depends on: #519 - [x] style lint - [x] docs - [X] move theory stubs to a separate PR, for easier tracking: #733 - [x] failing to parse the `LinarithConfig` option * Before or after merge? - [ ] Implement the `removeNe` preprocessor. - [ ] Add support for restricting to a single type. How to store a `Type` in `LinarithConfig`? * After merge - [ ] Teach `norm_num` to solve `example [LinearOrderedRing α] : (0 : α) < 37 := by norm_num`. - [ ] Port `zify_proof` (plumbing for `zify`), and add the `natToInt` preprocessor. Mostly done now, but see #741 before all the tests will work. - [ ] Port `cancel_denoms` tactic, and add the `cancelDenoms` preprocessor. - [ ] Add the `nlinarith` preprocessor and front-end syntax. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Remove the `MonadLift Option MetaM` instance which previously appeared in the middle of the `norm_num` implementation. This has been there since the port (#519) and my guess is that leaving it there was an oversight -- that @digama0 had intended either to move it earlier or to delete it entirely. Anyway, this PR takes the easiest path to removing it: de-instance the definition, and invoke it as a local instance in the places where it had been used in Mathlib. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/Lift.20from.20Option.20to.20MetaM)
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
Remove the `MonadLift Option MetaM` instance which previously appeared in the middle of the `norm_num` implementation. This has been there since the port (#519) and my guess is that leaving it there was an oversight -- that @digama0 had intended either to move it earlier or to delete it entirely. Anyway, this PR takes the easiest path to removing it: de-instance the definition, and invoke it as a local instance in the places where it had been used in Mathlib. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/Lift.20from.20Option.20to.20MetaM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another complete rewrite. This implements one
ringto rule them all: it incorporates bothring_expandringbehaviors, now under the namering. (ring_exphad some small (1.4x) performance issues that prevented it from being used by default; I'm hoping that those issues are fixed now, and we can revisit later if it becomes an issue.)