[Merged by Bors] - chore: remove instance of lift from Option to MetaM#18680
Closed
[Merged by Bors] - chore: remove instance of lift from Option to MetaM#18680
Option to MetaM#18680Conversation
Option to MetaM
PR summary c915a10a0cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Contributor
|
Thanks! bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Remove the `MonadLift Option MetaM` instance which previously appeared in the middle of the `norm_num` implementation. This has been there since the port (#519) and my guess is that leaving it there was an oversight -- that @digama0 had intended either to move it earlier or to delete it entirely. Anyway, this PR takes the easiest path to removing it: de-instance the definition, and invoke it as a local instance in the places where it had been used in Mathlib. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/Lift.20from.20Option.20to.20MetaM)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Option to MetaMOption to MetaM
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
Remove the `MonadLift Option MetaM` instance which previously appeared in the middle of the `norm_num` implementation. This has been there since the port (#519) and my guess is that leaving it there was an oversight -- that @digama0 had intended either to move it earlier or to delete it entirely. Anyway, this PR takes the easiest path to removing it: de-instance the definition, and invoke it as a local instance in the places where it had been used in Mathlib. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/Lift.20from.20Option.20to.20MetaM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
MonadLift Option MetaMinstance which previously appeared in the middle of thenorm_numimplementation. This has been there since the port (#519) and my guess is that leaving it there was an oversight -- that @digama0 had intended either to move it earlier or to delete it entirely.Anyway, this PR takes the easiest path to removing it: de-instance the definition, and invoke it as a local instance in the places where it had been used in Mathlib.
Zulip