Skip to content

[Merged by Bors] - chore: tidy various files#4304

Closed
Ruben-VandeVelde wants to merge 5 commits intomasterfrom
various-tidy
Closed

[Merged by Bors] - chore: tidy various files#4304
Ruben-VandeVelde wants to merge 5 commits intomasterfrom
various-tidy

Conversation

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde commented May 24, 2023

continuous_subtype_val <;>
-- TODO: the following are provable by `continuity` but it is too slow
-- porting note: the new `continuity` succeeds and it isn't too slow!
-- Porting note: used `continuity`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- Porting note: used `continuity`

I think just drop this, it's confusing without the context, and doesn't really need to be recorded.

@[continuity]
theorem truncate_const_continuous_family {X : Type _} [TopologicalSpace X] {a b : X} (γ : Path a b)
(t : ℝ) : Continuous ↿(γ.truncate t) := by
-- Porting note: used `continuity`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 25, 2023

bors d+

@bors
Copy link
Copy Markdown

bors bot commented May 25, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels May 25, 2023
@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request May 25, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented May 25, 2023

Canceled.

@ChrisHughes24
Copy link
Copy Markdown
Member

This can be merged after it's fixed

bors d+

@bors
Copy link
Copy Markdown

bors bot commented May 25, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor Author

I'll let #4360 go first in case it conflicts

@kim-em kim-em added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels May 26, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 26, 2023

This PR/issue depends on:

@ChrisHughes24
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 26, 2023
bors bot pushed a commit that referenced this pull request May 26, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented May 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: tidy various files [Merged by Bors] - chore: tidy various files May 26, 2023
@bors bors bot closed this May 26, 2023
@bors bors bot deleted the various-tidy branch May 26, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants