Skip to content

[Merged by Bors] - chore: fix upper/lowercase in comments#4360

Closed
urkud wants to merge 8 commits intomasterfrom
YK-fix-comment
Closed

[Merged by Bors] - chore: fix upper/lowercase in comments#4360
urkud wants to merge 8 commits intomasterfrom
YK-fix-comment

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented May 25, 2023

  • Run a non-interactive version of fix-comments.py on all files.
  • Go through the diff and manually add/discard/edit chunks.

Open in Gitpod

@urkud urkud added awaiting-review documentation Improvements or additions to documentation labels May 25, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 25, 2023

I skimmed through to Mathlib/RingTheory/Ideal/Over.lean, after which github wasn't showing me the diffs without clicking once for each file. I'd be happy to merge. If anyone wants to look through the tail, that's fine too.

lemmas. These show the quotient map `mk : M → S → Localization S` equals the
surjection `LocalizationMap.mk'` induced by the map
`monoid_of : localization_map S (localization S)` (where `of` establishes the
`monoid_of : localization_map S (Localization S)` (where `of` establishes the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about localization_map and monoid_of?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruben-VandeVelde , could you please have another look at this file?

urkud and others added 3 commits May 25, 2023 22:13
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just the one left.

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@urkud
Copy link
Copy Markdown
Member Author

urkud commented May 26, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 26, 2023
bors bot pushed a commit that referenced this pull request May 26, 2023
* Run a non-interactive version of `fix-comments.py` on all files.
* Go through the diff and manually add/discard/edit chunks.
@bors
Copy link
Copy Markdown

bors bot commented May 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: fix upper/lowercase in comments [Merged by Bors] - chore: fix upper/lowercase in comments May 26, 2023
@bors bors bot closed this May 26, 2023
@bors bors bot deleted the YK-fix-comment branch May 26, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants