Skip to content

[Merged by Bors] - feat: port RingTheory.FreeCommRing#3994

Closed
Komyyy wants to merge 67 commits intomasterfrom
reenableeta_RingTheory.FreeCommRing
Closed

[Merged by Bors] - feat: port RingTheory.FreeCommRing#3994
Komyyy wants to merge 67 commits intomasterfrom
reenableeta_RingTheory.FreeCommRing

Conversation

@Komyyy
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy commented May 15, 2023

@kim-em kim-em changed the title feat: port RingTheory.FreeCommRing, with reenableeta feat: port RingTheory.FreeCommRing May 16, 2023
@kim-em kim-em added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels May 16, 2023
@kim-em kim-em marked this pull request as ready for review May 16, 2023 04:26
@kim-em kim-em added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels May 16, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 16, 2023

This PR/issue depends on:

@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 16, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label May 16, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 17, 2023
bors bot pushed a commit that referenced this pull request May 17, 2023
- [x] depends on: #3414

original: #3087

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)


Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Mauricio Collares <mauricio@collares.org>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@bors
Copy link
Copy Markdown

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.FreeCommRing [Merged by Bors] - feat: port RingTheory.FreeCommRing May 17, 2023
@bors bors bot closed this May 17, 2023
@bors bors bot deleted the reenableeta_RingTheory.FreeCommRing branch May 17, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants