Skip to content

feat: port RingTheory.FreeCommRing#3087

Closed
ChrisHughes24 wants to merge 12 commits intomasterfrom
port/RingTheory.FreeCommRing
Closed

feat: port RingTheory.FreeCommRing#3087
ChrisHughes24 wants to merge 12 commits intomasterfrom
port/RingTheory.FreeCommRing

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member

@ChrisHughes24 ChrisHughes24 commented Mar 24, 2023


reenableeta: #3994

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@ChrisHughes24 ChrisHughes24 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Mar 24, 2023
@int-y1
Copy link
Copy Markdown
Contributor

int-y1 commented May 15, 2023

todo:

  • coe_eq find a proof

@Komyyy
Copy link
Copy Markdown
Contributor

Komyyy commented May 15, 2023

With reenableeta, this can be compiled.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented May 16, 2023

Closing in favour of #3994.

@kim-em kim-em closed this May 16, 2023
@Komyyy Komyyy deleted the port/RingTheory.FreeCommRing branch May 16, 2023 04:33
bors bot pushed a commit that referenced this pull request May 17, 2023
- [x] depends on: #3414

original: #3087

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)


Co-authored-by: Komyyy <pol_tta@outlook.jp>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Mauricio Collares <mauricio@collares.org>
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants